Build using mlocati/docker-php-extension-installer

Author: pjeby

Dockerfile

@@ -1,15 +1,18 @@
 # -------- Copy stuff from base images
+ARG PHP_VER=7.2.29
+ARG OS_VER=3.10
 
 FROM jwilder/dockerize:0.6.0 AS dockerize
 FROM bashitup/alpine-tools:latest AS tools
-FROM php:7.2.29-fpm-alpine3.10
+FROM php:$PHP_VER-fpm-alpine$OS_VER
 
 COPY --from=dockerize /usr/local/bin/dockerize /usr/bin/
 
 COPY --from=tools     /bin/yaml2json        /usr/bin/
 COPY --from=tools     /bin/modd             /usr/bin/
 COPY --from=tools     /bin/jq               /usr/bin/
 
+COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/bin/
 # -------- Add packages and build/install tools
 
 ENV LD_PRELOAD /usr/lib/preloadable_libiconv.so php
@@ -19,32 +22,10 @@ RUN apk --no-cache add \
 	&& \
 	apk --update add \
 		bash nginx nginx-mod-http-lua nginx-mod-http-lua-upstream \
-		supervisor ncurses certbot \
-		git wget curl libcurl openssh-client ca-certificates \
-		dialog libpq icu-libs imap-dev libzip \
-		libmcrypt libxslt libpng freetype libjpeg-turbo \
+		supervisor ncurses certbot git wget curl openssh-client ca-certificates \
+		dialog \
 	&& \
-    apk add --virtual .build-deps \
-		autoconf gcc make musl-dev linux-headers libffi-dev libzip-dev \
-		augeas-dev python-dev icu-dev sqlite-dev openssl-dev \
-		libmcrypt-dev libxslt-dev libpng-dev freetype-dev libjpeg-turbo-dev \
-	&& \
-	docker-php-ext-configure gd \
-		--with-gd \
-		--with-freetype-dir=/usr/include/ --with-png-dir=/usr/include/ \
-		--with-jpeg-dir=/usr/include/ \
-	&& \
-	docker-php-ext-configure zip --with-libzip=/usr/include \
-	&& \
-	docker-php-ext-configure imap --with-imap --with-imap-ssl \
-	&& \
-	docker-php-ext-install \
-		pdo_mysql mysqli \
-		imap gd exif intl xsl soap zip opcache && \
-	pecl install xdebug mcrypt-1.0.3 && \
-	docker-php-ext-enable mcrypt && \
-	docker-php-source delete && \
-	apk del .build-deps
+	install-php-extensions mcrypt pdo_mysql mysqli gd exif intl zip opcache
 
 # -------- Setup composer and runtime environment
 

README.md

@@ -163,6 +163,8 @@ If you want extreme backward compatibility with the default settings of `richarv
 * `NGINX_READABLE=.` and `NGINX_WRITABLE=.`, to make the entire codebase readable and writable by nginx+php (which is much less secure)
 * `NGINX_WORKERS=auto`
 * `PHP_LOG_ERRORS=false`
+* `EXTRA_EXTS=pgsql pdo_pgsql redis xsl soap xdebug` (if you need any of these extensions)
+* `EXTRA_APKS=nginx-mod-http-geoip nginx-mod-stream-geoip` (if you need nginx geoip modules)
 
 The following features of `richarvey/nginx-php-fpm` are not directly supported by this image, and must be configured in a different way:
 
@@ -213,9 +215,8 @@ services:
     build:
       context: https://github.com/dirtsimple/php-server.git
       args:
-        - EXTRA_APKS=ghostscript graphviz aspell-dev libmemcached-dev cyrus-sasl-dev openldap-dev
-        - EXTRA_EXTS=xmlrpc pspell ldap
-        - EXTRA_PECL=memcached
+        - EXTRA_APKS=ghostscript graphviz
+        - EXTRA_EXTS=xmlrpc pspell ldap memcached
     environment:
       - GIT_REPO=https://github.com/moodle/moodle.git
       - GIT_BRANCH=MOODLE_33_STABLE
@@ -227,6 +228,8 @@ For performance's sake, it's generally better to specify extras at build-time, b
 
 Specific versions of a PECL module can be forced by using a `:`, e.g. `EXTRA_PECL=mcrypt:1.0.2`.  (A `:` is used in place of a `-` so that the version can be stripped from the extension name in generated PHP .ini file(s).)
 
+As of the 2.x versions of this image, `EXTRA_EXTS` are built using [mlocati/docker-php-extension-installer](https://github.com/mlocati/docker-php-extension-installer/), so you no longer need to specify `EXTRA_APKS` for any of the extensions it supports, and you can build supported PECL extensions using `EXTRA_EXTS`, without needing `EXTRA_PECL`, unless you need to specify a particular module version, or need an extension that isn't supported by docker-php-extension-installer.  (But in such cases, you must explicitly list any needed packages in `EXTRA_APKS`, since the automatic installer won't be handling it for you.)
+
 ### Supervised Tasks
 
 Any files named `/etc/supervisor.d/*.ini` are included as part of the supervisord configuration, so that you can add your own supervised tasks.  (For example, if you wanted to add a mysql or openssh server.)  This image's own tasks are there as well, and can be overridden by your own substitutions in `/tpl/etc/supervisor.d` or a `DOCKERIZE_TEMPLATES` directory:
@@ -259,23 +262,27 @@ Please note that the modd process runs as **root**, which means that your config
 
 ### Version Info
 
-Builds of this image are tagged with multiple aliases to make it easy to pin specific revisions or to float by PHP version.  For example, a PHP 7.1.33 image with revision 1.4.6 of this container could be accessed via any of the following tags:
+Builds of this image are tagged with multiple aliases to make it easy to pin specific revisions or to float by PHP version.  For example, a PHP 7.1.33 image with release 1.4.6 of this container could be accessed via any of the following tags:
 
-* `7.1`, `7.1.33` - PHP version, with or without minor release, any container revision
-* `7.1-1.x`, `7.1.33-1.x` -- PHP version plus container major revision
-* `7.1.33-1.4.6 -- an exact revision of both PHP and the container
+* `7.1`, `7.1.33` - PHP version, with or without minor version, latest container release
+* `7.1-1.x`, `7.1.33-1.x` -- PHP version plus container major release
+* `7.1.33-1.4.6` -- an exact PHP revision and container release
 
-The `latest` tag will match the highest-numbered exact revision, while `unstable` tracks the `master` branch during development.
+The `unstable` tag tracks the `master` branch during development, with the highest PHP version currently in test.
 
 #### Version History
 
-| Tags          | Upstream Version                                             | PHP    | nginx  | mod lua | alpine |
-| ------------- | ------------------------------------------------------------ | ------ | ------ | ------- | ------ |
-| 1.0.x - 1.3.x | [1.3.10](https://gitlab.com/ric_harvey/nginx-php-fpm/tree/1.3.10) | 7.1.12 | 1.13.7 | 0.10.11 | 3.6    |
-| 1.4.0         | N/A                                                          | 7.1.32 | 1.14.2 | 0.10.15 | 3.9    |
-| 1.4.x         | N/A                                                          | 7.1.33 | 1.14.2 | 0.10.15 | 3.9    |
-| 7.1.33-1.4.x  | N/A                                                          | 7.1.33 | 1.14.2 | 0.10.15 | 3.9    |
-| 7.2.26-1.4.x  | N/A                                                          | 7.2.26 | 1.14.2 | 0.10.15 | 3.9    |
-| 7.2.29-2.0.x  | N/A                                                          | 7.2.29 | 1.16.2 | 0.10.15 | 3.10   |
-
-(Note: The 2.x version bump for 7.2.29  is due to the switch from alpine 3.9 to 3.10: if you're building complex things on top of this image, the base OS often matters quite a bit.)
+| Tags          | PHP    | nginx  | mod lua | alpine | Notes |
+| ------------- | ------ | ------ | ------- | ------ | ----- |
+| 7.2.29-2.0.x  | 7.2.29 | 1.16.2 | 0.10.15 | 3.10   | New extension build method for all 7.x-2.x versions |
+| 7.2.26-2.0.x  | 7.2.26 | 1.14.2 | 0.10.15 | 3.9    ||
+| 7.1.33-2.0.x  | 7.1.33 | 1.14.2 | 0.10.15 | 3.9    ||
+|  |  |  |  |  |   |
+| 7.2.26-1.4.x  | 7.2.26 | 1.14.2 | 0.10.15 | 3.9    | Old extension build method used from here down |
+| 7.1.33-1.4.x  | 7.1.33 | 1.14.2 | 0.10.15 | 3.9    ||
+|  |  |  |  |  |   |
+| 1.4.x         | 7.1.33 | 1.14.2 | 0.10.15 | 3.9    ||
+| 1.4.0         | 7.1.32 | 1.14.2 | 0.10.15 | 3.9    ||
+| 1.0.x - 1.3.x | 7.1.12 | 1.13.7 | 0.10.11 | 3.6    | Based on upstream [1.3.10][ric_harvey] |
+
+[ric_harvey]: https://gitlab.com/ric_harvey/nginx-php-fpm/tree/1.3.10

scripts/install-extras

@@ -7,8 +7,9 @@ uninstalled_apks() {
 }
 
 uninstalled_exts() {
-    ext_base="/usr/local/etc/php/conf.d/docker-php-ext-"
-    for ext; do [ -f "${ext_base}${ext%:*}.ini" ]  || echo $ext; done
+    local exts=($(php -m)) ext_base="/usr/local/etc/php/conf.d/docker-php-ext-"
+    shopt -s nocaseglob
+    for ext; do [[ " ${exts[*]} " == *"$ext"* || -f "${ext_base}${ext%:*}.ini" ]] || echo $ext; done
 }
 
 install_pecls() {
@@ -27,6 +28,6 @@ installs=$(uninstalled_exts $EXTRA_EXTS)
 pecls=$(   uninstalled_exts $EXTRA_PECL)
 
 if [[ "$apks"     ]]; then apk add $apks; fi
-if [[ "$installs" ]]; then docker-php-ext-install $installs; fi
+if [[ "$installs" ]]; then install-php-extensions $installs; fi
 if [[ "$pecls"    ]]; then install_pecls $pecls; fi