Skip to content

resolver="2" breaks support for Rust 1.48.0 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
link2xt opened this issue Sep 25, 2021 · 2 comments
Closed

resolver="2" breaks support for Rust 1.48.0 #28

link2xt opened this issue Sep 25, 2021 · 2 comments

Comments

@link2xt
Copy link

link2xt commented Sep 25, 2021

Fix #22 introduced resolver="2" option in Cargo.toml.

Even though MSRV is 1.51, it would be nice to avoid this as for deltachat-core-rust MSRV is 1.48.0 and updating async-tar breaks CI.

@link2xt link2xt changed the title resolver="2" breaks support for Rust resolver="2" breaks support for Rust 1.48.0 Sep 25, 2021
@link2xt
Copy link
Author

link2xt commented Sep 25, 2021

If it's difficult, maybe we should discuss bumping MSRV to 1.51 for deltachat-core-rust.

There is another dependency, zeroize_derive, which is used by pgp and crypto code, which also broke rust 1.48.0 compatibility recently: iqlusioninc/crates#755

But even Debian sid still has rustc 1.50.0

@dignifiedquire
Copy link
Owner

@link2xt deltachat-core-rust will need to switch to a newer rust with the next rpgp release as well. All new crypto release have an MSRV of 1.51 and it will likely not be too long until even newer, due to the const improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants