The enhancers now create the Overtype (as they should).

Author: ntwigg

browser-extension/src/datamodel/enhancer.ts

@@ -1,3 +1,5 @@
+import type { OverType } from '../overtype/mock-overtype'
+
 /**
  * stores enough info about the location of a draft to:
  * - display it in a table
@@ -16,7 +18,7 @@ export interface CommentEnhancer<T extends CommentSpot = CommentSpot> {
    * whenever a new `textarea` is added to any webpage, this method is called.
    * if we return non-null, then we become the handler for that text area.
    */
-  identifyContextOf(textarea: HTMLTextAreaElement): T | null
+  tryToEnhance(textarea: HTMLTextAreaElement): [OverType, T] | null
 
   generateIcon(context: T): string
   generateDisplayTitle(context: T): string

browser-extension/src/datamodel/handlers/github-handler.ts

@@ -1,3 +1,4 @@
+import { OverType } from '../../overtype/mock-overtype'
 import type { CommentEnhancer, CommentSpot } from '../enhancer'
 
 export type GitHubCommentType =
@@ -30,7 +31,7 @@ export class GitHubHandler implements CommentEnhancer<GitHubContext> {
     ]
   }
 
-  identifyContextOf(textarea: HTMLTextAreaElement): GitHubContext | null {
+  tryToEnhance(textarea: HTMLTextAreaElement): [OverType, GitHubContext] | null {
     // Only handle GitHub domains
     if (!window.location.hostname.includes('github')) {
       return null
@@ -103,7 +104,10 @@ export class GitHubHandler implements CommentEnhancer<GitHubContext> {
       unique_key,
     }
 
-    return context
+    // Create OverType instance for this textarea
+    const overtype = new OverType(textarea)
+
+    return [overtype, context]
   }
 
   generateDisplayTitle(context: GitHubContext): string {

browser-extension/src/datamodel/handlers/reddit-handler.ts

@@ -1,3 +1,4 @@
+import { OverType } from '../../overtype/mock-overtype'
 import type { CommentEnhancer, CommentSpot } from '../enhancer'
 
 export type RedditCommentType = 'REDDIT_POST_NEW' | 'REDDIT_COMMENT_NEW' | 'REDDIT_COMMENT_EDIT'
@@ -14,7 +15,7 @@ export class RedditHandler implements CommentEnhancer<RedditContext> {
     return ['REDDIT_POST_NEW', 'REDDIT_COMMENT_NEW', 'REDDIT_COMMENT_EDIT']
   }
 
-  identifyContextOf(textarea: HTMLTextAreaElement): RedditContext | null {
+  tryToEnhance(textarea: HTMLTextAreaElement): [OverType, RedditContext] | null {
     // Only handle Reddit domains
     if (!window.location.hostname.includes('reddit')) {
       return null
@@ -80,7 +81,10 @@ export class RedditHandler implements CommentEnhancer<RedditContext> {
       unique_key,
     }
 
-    return context
+    // Create OverType instance for this textarea
+    const overtype = new OverType(textarea)
+
+    return [overtype, context]
   }
 
   generateDisplayTitle(context: RedditContext): string {

browser-extension/src/datamodel/registries.ts

@@ -1,3 +1,4 @@
+import type { OverType } from '../overtype/mock-overtype'
 import type { CommentEnhancer, CommentSpot } from './enhancer'
 import { GitHubHandler as GitHubEnhancer } from './handlers/github-handler'
 import { RedditHandler as RedditEnhancer } from './handlers/reddit-handler'
@@ -6,6 +7,7 @@ export interface EnhancedTextarea<T extends CommentSpot = CommentSpot> {
   element: HTMLTextAreaElement
   context: T
   handler: CommentEnhancer<T>
+  overtype: OverType
 }
 
 export class EnhancerRegistry {
@@ -33,9 +35,10 @@ export class EnhancerRegistry {
   identifyTextarea(textarea: HTMLTextAreaElement): EnhancedTextarea<any> | null {
     for (const handler of this.enhancers) {
       try {
-        const context = handler.identifyContextOf(textarea)
-        if (context) {
-          return { context, element: textarea, handler }
+        const result = handler.tryToEnhance(textarea)
+        if (result) {
+          const [overtype, context] = result
+          return { context, element: textarea, handler, overtype }
         }
       } catch (error) {
         console.warn('Handler failed to identify textarea:', error)

browser-extension/tsconfig.json

@@ -42,5 +42,5 @@
   },
   "exclude": ["node_modules", ".output", "dist"],
   "extends": "./.wxt/tsconfig.json",
-  "include": ["src/entrypoints/**/*", "*.config.ts", ".wxt/wxt.d.ts", "tests/**/*"]
+  "include": ["src/**/*", "*.config.ts", ".wxt/wxt.d.ts", "tests/**/*"]
 }