Default depth for cbmc/jbmc should be UINT32_MAX

This sets the default "depth" options to be UINT32_MAX in both
cbmc and jbmc. This removes the need for special case handling
and simplifies the depth checking.

Fixes #2295

Author: TGWDB

jbmc/src/jbmc/jbmc_parse_options.cpp

@@ -113,6 +113,7 @@ void jbmc_parse_optionst::set_default_options(optionst &options)
 
   // Other default
   options.set_option("arrays-uf", "auto");
+  options.set_option("depth", UINT32_MAX);
 }
 
 void jbmc_parse_optionst::get_command_line_options(optionst &options)

src/cbmc/cbmc_parse_options.cpp

@@ -117,6 +117,7 @@ void cbmc_parse_optionst::set_default_options(optionst &options)
 
   // Other default
   options.set_option("arrays-uf", "auto");
+  options.set_option("depth", UINT32_MAX);
 }
 
 void cbmc_parse_optionst::get_command_line_options(optionst &options)

src/goto-symex/symex_main.cpp

@@ -612,7 +612,7 @@ void goto_symext::execute_next_instruction(
     merge_gotos(state);
 
   // depth exceeded?
-  if(symex_config.max_depth != 0 && state.depth > symex_config.max_depth)
+  if(state.depth > symex_config.max_depth)
   {
     // Rule out this path:
     symex_assume_l2(state, false_exprt());