Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual symbol overrides from the SecurityService #149

Open
dickwolff opened this issue Jan 5, 2025 · 1 comment
Open

Allow manual symbol overrides from the SecurityService #149

dickwolff opened this issue Jan 5, 2025 · 1 comment
Labels
Enhancement Request an enhancement to the tool Waiting for PR Waiting for a PR to be merged

Comments

@dickwolff
Copy link
Owner

dickwolff commented Jan 5, 2025

For example IE00B3RBWM25 is VWRL. As a Dutch customer, I purchase it at Euronext (AS). But Yahoo finance result is VWRL.L (in GBp). Same thing goes for IE00B02KXK85, which should be FXAC.AS.

Proposed solution is to provide a file with key value pairs in which users can provide their own overrides. This file (if present) is then read in security service (similar to the cache setup) and used instead of any Yahoo Finance result.

overrides.txt

IE00B3RBWM25=VWRL.AS
IE00B02KXK85=FXAC.AS

File must also be volume mounted via Docker, if the user wants to use it.

@dickwolff dickwolff self-assigned this Jan 5, 2025
@dickwolff dickwolff added DEGIRO Related to DEGIRO Enhancement Request an enhancement to the tool labels Jan 5, 2025
@dickwolff dickwolff removed their assignment Jan 9, 2025
@dickwolff dickwolff changed the title Allow DEGIRO symbol overrides Allow symbol overrides Jan 15, 2025
@dickwolff dickwolff changed the title Allow symbol overrides Allow manual symbol overrides Jan 15, 2025
@dickwolff dickwolff removed the DEGIRO Related to DEGIRO label Jan 15, 2025
@dickwolff dickwolff changed the title Allow manual symbol overrides Allow manual symbol overrides from the SecurityService Jan 16, 2025
@dickwolff dickwolff added the Waiting for PR Waiting for a PR to be merged label Jan 17, 2025
@dickwolff
Copy link
Owner Author

This PR is waiting for #148 to be merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request an enhancement to the tool Waiting for PR Waiting for a PR to be merged
Projects
None yet
Development

No branches or pull requests

1 participant