Skip to content

Commit abafc21

Browse files
authored
opentelemetry-exporter-prometheus-remote-write: workaround build failure with PyPy 3.8 (open-telemetry#3480)
Find a version that has a wheel for PyPy 3.8 skipping the failing test while we bump the baseline to 3.9.
1 parent 2c0033f commit abafc21

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

exporter/opentelemetry-exporter-prometheus-remote-write/test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ asgiref==3.8.1
22
certifi==2024.7.4
33
charset-normalizer==3.3.2
44
# We can drop this after bumping baseline to pypy-39
5-
cramjam==2.1.0; platform_python_implementation == "PyPy"
5+
cramjam==2.8.0; platform_python_implementation == "PyPy"
66
cramjam==2.8.4; platform_python_implementation != "PyPy"
77
Deprecated==1.2.14
88
idna==3.7

exporter/opentelemetry-exporter-prometheus-remote-write/tests/test_prometheus_remote_write_exporter.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# limitations under the License.
1414

1515
import unittest
16+
from platform import python_implementation
1617
from unittest.mock import patch
1718

1819
import pytest
@@ -282,6 +283,10 @@ def test_invalid_tls_config_key_only_param(self):
282283
)
283284

284285

286+
@pytest.mark.skipif(
287+
python_implementation() == "PyPy",
288+
reason="Fails with pypy 3.8, bump cramjam when 3.9 is baseline",
289+
)
285290
# Ensures export is successful with valid export_records and config
286291
@patch("requests.post")
287292
def test_valid_export(mock_post, prom_rw, metric):

0 commit comments

Comments
 (0)