patch failing on ubuntu 16.04 kernel (4.4.0-57)

[poine]

I am trying to apply your patch to a ubuntu 16.04 kernel tree and it is failing:

I have installed the kernel source package as per (https://wiki.ubuntu.com/Kernel/BuildYourOwnKernel)
When trying to apply your patch, i get the following:

poine@adam /usr/src/linux-source-4.4.0/linux-4.4.0 $ sudo patch --dry-run -p1 < ../../nvidia-shield-controller-driver/driver/0001-Revert-staging-ozwpan-Remove-from-tree.patch
checking file MAINTAINERS
Hunk #1 succeeded at 10288 with fuzz 2 (offset -848 lines).
checking file drivers/staging/Kconfig
Hunk #1 succeeded at 78 with fuzz 2 (offset 8 lines).
checking file drivers/staging/Makefile
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED
checking file drivers/staging/ozwpan/Kconfig
checking file drivers/staging/ozwpan/Makefile
checking file drivers/staging/ozwpan/README
checking file drivers/staging/ozwpan/TODO
checking file drivers/staging/ozwpan/ozappif.h
[...]

any suggestion on what i am doing wrong ?

Best Regards

[devmapal]

Hi,
the patches are generated against a vanilla kernel that is also much more recent that the kernel in ubuntu 16.04, so it is very well possible that the patches can't directly be applied to the kernel shipped with ubuntu 16.04.

I'll see if I can generate some patches for the ubuntu 16.04 kernel as well.

Btw, I develop the kernle module here: https://github.com/devmapal/linux

[poine]

Hi Fabian

Don't bother for now. I have managed to apply the part that was failing "by hand" (I edited the Makefile, it's just one line). The rest applied cleanly. It is still compiling. I'll let you know how it works for me.

I will look at the repository you pointed too.

While the kernel is building, i tried the rest of your instructions and the pairing step failed with an uninformative message:

poine@adam /usr/src/linux-source-4.4.0/linux-4.4.0 $ sudo wpa_cli -i wls3 p2p_group_add persistent
FAIL

any idea on that one?

[devmapal]

Maybe the wpa_supplicant daemon is not running or configured correctly? I would try to maybe run the wpa_supplicant daemon with debug output ("-dd" flags) to see whats going on

[poine]

Hi Fabian

Good news, the module built and inserts
adam linux-source-4.4.0 # modprobe ozwpan g_net_dev=p2p-wls3

Dec 21 16:10:26 adam kernel: [ 2289.728505] ozwpan: module is from the staging directory, the quality is unknown, you have been warned.
Dec 21 16:10:26 adam kernel: [ 2289.730693] ozwpan ozwpan: Ozmo Devices WPAN
Dec 21 16:10:26 adam kernel: [ 2289.730699] ozwpan ozwpan: new USB bus registered, assigned bus number 8
Dec 21 16:10:26 adam kernel: [ 2289.733053] usb usb8: New USB device found, idVendor=1d6b, idProduct=0001
Dec 21 16:10:26 adam kernel: [ 2289.733058] usb usb8: New USB device strings: Mfr=3, Product=2, SerialNumber=1
Dec 21 16:10:26 adam kernel: [ 2289.733060] usb usb8: Product: Ozmo Devices WPAN
Dec 21 16:10:26 adam kernel: [ 2289.733063] usb usb8: Manufacturer: Linux 4.4.0-57-lowlatency Ozmo WPAN
Dec 21 16:10:26 adam kernel: [ 2289.733066] usb usb8: SerialNumber: ozwpan
Dec 21 16:10:26 adam kernel: [ 2289.733526] hub 8-0:1.0: USB hub found
Dec 21 16:10:26 adam kernel: [ 2289.733536] hub 8-0:1.0: 8 ports detected

Now I am still stuck with the pairing process. It looks like network-manager/systemd/dbus and co make things overly complicated. I'll keep reading and keep you posted

[devmapal]

That's great, happy to hear that you were able to get the module compiled and inserted. When you get the pairing process to work, I would love to hear about it, also so that I can add the explanation to the README.md.