Skip to content

Commit c2b4c08

Browse files
committed
fix: kinha comments
1 parent d248f54 commit c2b4c08

File tree

1 file changed

+14
-22
lines changed

1 file changed

+14
-22
lines changed

src/features/twitter/services/twitter-service.test.ts

+14-22
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,19 @@ import { loggerMock } from '@/shared/test-helpers/mocks/logger.mock';
99
import { TwitterService } from './twitter-service';
1010

1111
describe('[Service] Twitter Service', () => {
12-
let twitterService: TwitterService;
13-
14-
let mockLogger: Logger;
15-
let mockHttp: HttpAdapter;
12+
let sut: TwitterService;
13+
const mockLogger = mock<Logger>(loggerMock);
14+
const mockHttp = mock<HttpAdapter>(httpAdapterMock);
1615

1716
beforeEach(() => {
18-
mockLogger = mock<Logger>(loggerMock);
19-
mockHttp = mock(httpAdapterMock);
20-
21-
twitterService = new TwitterService(mockLogger, mockHttp);
17+
sut = new TwitterService(mockLogger, mockHttp);
2218
});
2319

2420
describe('getTwitterOAuthToken', () => {
2521
it('return data with success', async () => {
2622
const input = faker.string.alpha({ length: 10 });
2723

28-
vi.spyOn(mockHttp, 'post').mockResolvedValueOnce({
24+
mockHttp.post.mockResolvedValueOnce({
2925
data: {
3026
access_token: faker.string.alpha({ length: 10 }),
3127
expires_in: 7200,
@@ -36,7 +32,7 @@ describe('[Service] Twitter Service', () => {
3632
statusText: 'OK',
3733
});
3834

39-
const result = await twitterService.getTwitterOAuthToken(input);
35+
const result = await sut.getTwitterOAuthToken(input);
4036

4137
expect(mockLogger.info).toBeCalled();
4238
expect(result).toEqual({
@@ -50,13 +46,11 @@ describe('[Service] Twitter Service', () => {
5046
it('error on post', async () => {
5147
const input = faker.string.alpha({ length: 10 });
5248

53-
vi.spyOn(mockHttp, 'post').mockRejectedValueOnce(
54-
new Error('Error on post')
55-
);
49+
mockHttp.post.mockRejectedValueOnce(new Error('Error on post'));
5650

57-
await expect(
58-
twitterService.getTwitterOAuthToken(input)
59-
).rejects.toThrowError('Error on post');
51+
await expect(sut.getTwitterOAuthToken(input)).rejects.toThrowError(
52+
'Error on post'
53+
);
6054
expect(mockLogger.error).toBeCalledWith(
6155
'Error on getTwitterOAuthToken in twitter service -Error: Error on post'
6256
);
@@ -67,7 +61,7 @@ describe('[Service] Twitter Service', () => {
6761
it('return data with success', async () => {
6862
const input = faker.string.alpha({ length: 10 });
6963

70-
vi.spyOn(mockHttp, 'get').mockResolvedValueOnce({
64+
mockHttp.get.mockResolvedValueOnce({
7165
data: {
7266
data: {
7367
id: faker.string.alpha(),
@@ -79,7 +73,7 @@ describe('[Service] Twitter Service', () => {
7973
statusText: 'OK',
8074
});
8175

82-
const result = await twitterService.getTwitterUser(input);
76+
const result = await sut.getTwitterUser(input);
8377

8478
expect(mockLogger.info).toBeCalled();
8579
expect(result).toEqual({
@@ -92,11 +86,9 @@ describe('[Service] Twitter Service', () => {
9286
it('error on get', async () => {
9387
const input = faker.string.alpha({ length: 10 });
9488

95-
vi.spyOn(mockHttp, 'get').mockRejectedValueOnce(
96-
new Error('Error on get')
97-
);
89+
mockHttp.get.mockRejectedValueOnce(new Error('Error on get'));
9890

99-
await expect(twitterService.getTwitterUser(input)).rejects.toThrowError(
91+
await expect(sut.getTwitterUser(input)).rejects.toThrowError(
10092
'Error on get'
10193
);
10294
expect(mockLogger.error).toBeCalledWith(

0 commit comments

Comments
 (0)