Skip to content

Avoid using .textContent #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid using .textContent #31

wants to merge 1 commit into from

Conversation

@developit
Copy link
Owner

@developit developit commented Aug 4, 2019

@danielweck
Copy link

danielweck commented Mar 30, 2021

Indeed, .textContent is an order of magnitude slower. Apart from the code conflicts, is there anything blocking this PR? This is a pretty straight-forward and safe change, as you are checking n.nodeType === 3 (Text node, which is CharacterData and therefore has the data property).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@developit @danielweck