Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CI #8

Open
sameo opened this issue Mar 19, 2021 · 2 comments
Open

Missing CI #8

sameo opened this issue Mar 19, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@sameo
Copy link
Collaborator

sameo commented Mar 19, 2021

This project has no CI, shame on us.

We want to implement a github actions based CI that would:

  • Build the project, with the stable, beta and nightly toolchains
  • Run all unit and integration tests
  • Run cargo clippy
  • Run cargo fmt

for each pending PR.

Any of this step failing should prevent the PR to be merged.

@thomasgouveia
Copy link

See PR #10

@sameo , I do not understand why we have to build with beta and nightly toolchains ?

Also, do we have to create a release after each merge on main to allow people to download a binary ?

@sameo
Copy link
Collaborator Author

sameo commented Mar 23, 2021

@thomasgouveia

See PR #10

@sameo , I do not understand why we have to build with beta and nightly toolchains ?

Because there is no reason our code would not build with those toolchains, and this would let us anticipate any breakage when we move to newer toolchains.

Also, do we have to create a release after each merge on main to allow people to download a binary ?

No, we should only generate a release when we tag the main branch (a.k.a. a release).

@sameo sameo added the good first issue Good for newcomers label Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants