Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating Icon fa6 example is using fa5 #81

Open
umer936 opened this issue Sep 11, 2024 · 9 comments
Open

Templating Icon fa6 example is using fa5 #81

umer936 opened this issue Sep 11, 2024 · 9 comments

Comments

@umer936
Copy link
Contributor

umer936 commented Sep 11, 2024

https://sandbox.dereuromark.de/sandbox/templating-examples/icon-sets/fa6

has

<link rel="stylesheet" href="/assets/fontawesome-free/css/solid.css">

which goes to fa5. I noticed this because I was doing the exact same error in my project so I checked your sandbox and found the same thing 😄

@dereuromark
Copy link
Owner

Where did you see this linked? I think I removed that a while ago
It is after all only a showcase of the plugin and possible sets
Currently only fa4 should be available via
https://sandbox.dereuromark.de/sandbox/templating-examples/icons

@dereuromark
Copy link
Owner

If you have a fix on how to pull fa6, maybe you can make a PR here, and we can reactivate that link/action too :)

@umer936
Copy link
Contributor Author

umer936 commented Sep 12, 2024

Lol I'm not sure where I got to that link from. Google somewhere maybe?


I was unable to get a version of sandbox going to test my changes.

AssetCompress couldn't find the correct files and then also didn't have an assets folder in webroot so I ended up with "Cannot find meta data file path /web/cakephp-sandbox/webroot/assets/font-awesome/less/variables.less for Templating\View\Icon\FontAwesome4Icon."

Not sure if I missed a step of grabbing those.


Regardless, essentially https://github.com/dereuromark/cakephp-sandbox/blob/master/plugins/Sandbox/templates/TemplatingExamples/icon_sets.php has it loading solid.css, but what's at solid.css is font-awesome 5.15.4 from https://sandbox.dereuromark.de/assets/fontawesome-free/css/solid.css , not fa6. In my case I just changed the CDN to the fa6 link rather than the fa5 link.

@dereuromark
Copy link
Owner

Check setup.sh and build.sh
They Show the steps

@dereuromark
Copy link
Owner

The assets folder should be Auto created using the setup.sh

@umer936
Copy link
Contributor Author

umer936 commented Sep 12, 2024

Ah. I totally didn't read SETUP.md lol. Ok I'll look later.

@dereuromark
Copy link
Owner

@umer936 Did you have a chance to revisit?

@umer936
Copy link
Contributor Author

umer936 commented Oct 28, 2024

I did but kept getting stuck. I tried just running it but I don't have php or composer installed on the host system, just in docker containers. So then I tried https://github.com/dereuromark/sandbox-docker which also relies on php.

So I spun up a devcontainer + docker-compose with php and mysql and ran the setup with just the main project and it mostly succeeded but then I ended up with asset_compress issues likely because I didn't have certain build packages from npm. The webpage shows "could not locate bootstrap.css in css-combined."

@dereuromark
Copy link
Owner

dereuromark commented Oct 28, 2024

Try ddev
It usually ships with a lot out of the box

As for bootstrap.css missing:
Did you run composer assets etc as per build.sh?
That all assets are downloaded before you try building the asset compress file(s)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants