Replicas on same node #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: should this check also be done for StatefulSets? |
|
In my opinion, it makes sense to include statefulsets |
|
@marians @pipo02mix Thank you both for this report! Yes probably more importantly so with sts imho. |
13 tasks
|
@derailed Just added support for StatefulSets. I'd welcome a review. |
derailed
requested changes
May 4, 2021
| // checkSameNode verifies if all replicas of the StatefulSet are running on | ||
| // the same node. | ||
| func (s *StatefulSet) checkSameNode(ctx context.Context, st *appsv1.StatefulSet) { | ||
| if *st.Spec.Replicas <= 1 { |
| return | ||
| } | ||
|
|
||
| nodeMap := make(map[string]int) |
There was a problem hiding this comment.
Don't think we need to count here ie if the node is already in the map the pods are collocated
s.ListPodsBySelector(st.Namespace, st.Spec.Selector
make(map[string]struct{}, len(oo))
if _, ok := nodeMap[pod.Spec.NodeName]; ok {
s.AddCode(...)
returnThat said I don't think these are valid general checks ie ES multiple shards can land on the same node? Thus that would raise a false positive??
|
Closing, as I'm not working on this any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
This PR implements a check that issues a warning if all replicas of a deployment are scheduled to the same host.
Preview: