Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Drop Shadow Styles #1774

Open
6 tasks
scurker opened this issue Dec 19, 2024 · 0 comments
Open
6 tasks

Update Drop Shadow Styles #1774

scurker opened this issue Dec 19, 2024 · 0 comments
Milestone

Comments

@scurker
Copy link
Member

scurker commented Dec 19, 2024

Shadows and fills can be used to show elevation. Our initial approach is to limit the number of shadows and provide the following semantic meaning:

Overlay = Any element that goes over content.
Raised = Any element that rests directly on the background / base or a sunken fill.

We should add 2 new global level variables for each of the new drop shadow styles:

--drop-shadow-overlay: 0 8px 8px -4px rgba(0, 0, 0, 0.04), 0 20px 24px -4px rgba(51, 51, 51, 0.08);
--drop-shadow-raised: 0 2px 4px -2px rgba(51, 51, 51, 0.08), 0 4px 8px -2px rgba(0, 0, 0, 0.04);

Overlay

All of the below components should inherit from --drop-shadow-overlay:

  • Combobox
  • OptionsMenu (+ future ActionMenu work)
  • Dialogs/Alert/Modals
  • LoaderOverlay
  • BottomSheet

Raised

All of the below components should inherit from --drop-shadow-raised:

  • Panel
@scurker scurker added this to the Future milestone Dec 19, 2024
@scurker scurker modified the milestones: Future, Q1 2025 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant