Update prereq.sh to fix bug report #2356. Make the rpm based installa… #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allation block look the same as the apt one above it by instaling 2 packages instead of just python39.
|
lgtm. |
dweineha
approved these changes
Oct 24, 2024
dweineha
left a comment
dweineha
left a comment
There was a problem hiding this comment.
Installs an extra package and removes a superfluous newline. Seems obviously correct.
Collaborator
|
@nthorne-dell Omnia does not support rocky 9.3 |
Collaborator
|
run omnia-checkers |
Collaborator
|
Can one of the admins verify this patch? |
Collaborator
|
@abhishek-sa1 let's not ignore PRs just because we don't offer support for a particular OS version. This seems like it was an obvious, non-breaking fix. We should be able to accept these types of changes. |
Collaborator
|
@lwilson Its not only due to OS support, currently omnia support python3.11 in latest version and already necessary changes made with respect to new flow. It handles installing pip packages as well. Please refer screenshot below.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved by this Pull Request
#2356
Fixes #
Description of the Solution
Please describe the solution provided and how it resolves the associated issues.
Suggested Reviewers
If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.