fix restart notice issue and test regression

Author: riofriz

src/client/settings/store/restart-notice.ts

@@ -116,7 +116,7 @@ export const pendingReasons = async (
     return null;
   }
 
-  const key = state.reasons.join("|");
+  const key = JSON.stringify(state.reasons);
   if (!state.pending || key === lastShownReasons) return null;
   lastShownReasons = key;
   return state.reasons;

tests/unit/restart-notice.test.ts

@@ -36,6 +36,11 @@ const loadNotice = async () => {
   return import("../../src/client/settings/store/restart-notice");
 };
 
+const loadFresh = async (tag: string) => {
+  stubWindow();
+  return import(`../../src/client/settings/store/restart-notice?${tag}`);
+};
+
 describe("restart notice state check", () => {
   beforeEach(() => {
     calls = [];
@@ -64,6 +69,26 @@ describe("restart notice state check", () => {
     expect(await pendingReasons(() => null)).toBeNull();
   });
 
+  test("keeps split reasons distinct from one reason holding a separator", async () => {
+    const { pendingReasons } = await loadNotice();
+    stubFetch(jsonOnce({ pending: true, reasons: ['plugin "a|b" was added'] }));
+    expect(await pendingReasons(() => null)).toEqual(['plugin "a|b" was added']);
+
+    stubFetch(jsonOnce({ pending: true, reasons: ['plugin "a', 'b" was added'] }));
+    expect(await pendingReasons(() => null)).toEqual([
+      'plugin "a',
+      'b" was added',
+    ]);
+  });
+
+  test("still notifies when a pending restart carries no reasons", async () => {
+    const { pendingReasons } = await loadFresh("empty-reasons");
+    stubFetch(jsonOnce({ pending: true, reasons: [] }));
+
+    expect(await pendingReasons(() => null)).toEqual([]);
+    expect(await pendingReasons(() => null)).toBeNull();
+  });
+
   test("returns nothing when the restart is not pending", async () => {
     const { pendingReasons } = await loadNotice();
     stubFetch(jsonOnce({ pending: false, reasons: ['engine "gamma" was added'] }));