Skip to content

pushState() still occurs when returning false in pjax:error event #661

Open
@nickelfault

Description

@nickelfault

When an ajax request fails and you return false in the pjax:error event, I don't think pushState() should still be executed. When this happens you end up with an incorrect URL in the address bar. In my case, on a failure I display an alert to the user (404 not found, etc). In this case the user ends up with an inconsistent state, they see different content than the URL should provide, and if they refresh the page they'd get a whole new set of content. I've submitted a pull request that fixes the problem for me, not sure if you'd want to merge it or not.

#660

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions