Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version with a host of patches from various forks included - now supports ruby 1.9 #23

Open
kristianmandrup opened this issue Jun 17, 2010 · 2 comments

Comments

@kristianmandrup
Copy link

Check it out at: http://github.com/kristianmandrup/github-gem

@drnic
Copy link
Collaborator

drnic commented Jan 31, 2011

I am so scared to attempt to merge this in; but very keen.

Is the 0.4.6 history summary the sum total of all the patches?

+== 0.4.6 2010-30-11
+Fixed Shell bug using fork from 'bronson'
+  replace @error = err if err.any?
+  replace @out = out if err.any?
+
+Refactored into:
+  replace @error = err unless err.empty?
+  replace @out = out unless out.empty?
+
+Also added String extension just in case bug is elsewhere...
+
+class String 
+  def any?
+    !empty?
+  end
+end

@drnic
Copy link
Collaborator

drnic commented Jan 31, 2011

Arhh, pooey, you have merged in stuff I just merged in. Damn.

Do you have time to check whether your branch matches with the current HEAD?

Grab me on skype at nicwilliams if you want to talk too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants