Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-request and review before merge methods #16

Open
barryk opened this issue Jan 19, 2010 · 0 comments
Open

pull-request and review before merge methods #16

barryk opened this issue Jan 19, 2010 · 0 comments

Comments

@barryk
Copy link

barryk commented Jan 19, 2010

These two go hand-in-hand really. But the existing pull-request command is actually only generating text it's not doing a github pull-request. This renames the existing pull-request command to pull-request-text and adds a pull-request command to issue a github pull-request.

http://github.com/barryk/github-gem/tree/PullRequest

Additionally, a maintainer may be frequently pulling in branches, testing them, merging them, pushing back to github, or perhaps testing, failing, writing a message for why. This adds basic code review commands:
review
review-pass
review-fail
with usage such as:
github review OtherUser/BranchName

test test test

github review-fail

editor opens, type a response as to why you failed this

or

github review-pass

merges into master, and pushes master back to github.

http://github.com/barryk/github-gem/tree/ReviewBranch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant