Class Button has bug with calculate width button

[Elstar]

<?php

namespace DefStudio\Telegraph\Keyboard;

class Button
{
...
public function get_width(): float
  {
      if ($this->width === 0) {
          return 1;
      }

      return round($this->width / 100, 1);
  }

So bug is in round precision, it must be 2 numbers after point, because if button width will be 0.25 (4 buttons in row) this method return 0.3 and it will be 3 buttons on row

[fabio-ivona]

Hi! Thanks for pointing this out! We'll fix soon and it will be available in next release

[fabio-ivona]

fixed in #169

[Elstar]

It's 4 rows with (4,4,1,4) buttons

[fabio-ivona]

Sorry, I can't get to recreate the issue, i made this:

Telegraph::message('test')->keyboard(Keyboard::make()
        ->button('1')->action('test')->width(0.25)
        ->button('2')->action('test')->width(0.25)
        ->button('3')->action('test')->width(0.25)
        ->button('4')->action('test')->width(0.25)
        ->button('5')->action('test')->width(1)
        ->button('6')->action('test')->width(0.25)
        ->button('7')->action('test')->width(0.25)
        ->button('8')->action('test')->width(0.25)
        ->button('9')->action('test')->width(0.25)
        ->button('10')->action('test')->width(0.25)
        ->button('11')->action('test')->width(0.25)
        ->button('12')->action('test')->width(0.25)
        ->button('13')->action('test')->width(0.25))->send()

and obtained:

could you show me some failing code?

[Elstar]

Could you please test by row method and without width

Telegraph::message('test')->keyboard(Keyboard::make()
  ->row([
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
  ])
  ->row([
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
  ])
  ->row([
      Button::make('url')->url('https://t.me/share/url?url=default')
  ])
  ->row([
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
  ])
  ->row([
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
      Button::make('action')->action('test')->param('param1', 1)->param('param2', 2),
  ])
)->send();

[fabio-ivona]

same result:

[Elstar]

Oh mb it's already fixed I'll try later check it without my hack) Thx a lot!