GitHub - Authorization failures due to empty Secret env var

[anakin87]

Describe the bug
Accessing public repositories doesn't require a GitHub token.

When we set a Secret corresponding to an env var in github_token:

• If the env var is not present, we fail with an expressive error message.
• If the env var is set but empty (as it can happen on some platforms), we end up passing headers["Authorization"] = "Bearer", causing the request to fail.

I would not say it's a proper bug, but we can make the implementation more robust.

To Reproduce

from haystack_integrations.components.connectors.github import GitHubIssueViewer
from haystack.utils import Secret
import os

os.environ["GITHUB_TOKEN"] = ""

viewer = GitHubIssueViewer(github_token=Secret.from_env_var("GITHUB_TOKEN"))

result = viewer.run(url="https://github.com/deepset-ai/haystack-core-integrations/issues/2373")

# requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: ...

[anakin87]

@julian-risch I'd appreciate your input.

Do you think that if Secret.from_env_var is set but the env var is empty, we should simply avoid passing the Authorization header?

[julian-risch]

I believe that's a good idea, yes. Then the request would still work for public repositories and only fail for private repos.

[yashv6655]

@julian-risch @anakin87 I would like to take this one if possible. I've opened a PR.