Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to run a groovy file in python results in a disconnect #97

Closed
chipkent opened this issue Aug 13, 2024 · 0 comments · Fixed by #175
Closed

Attempting to run a groovy file in python results in a disconnect #97

chipkent opened this issue Aug 13, 2024 · 0 comments · Fixed by #175
Assignees
@bmingles
Labels
bug Something isn't working
Milestone
November 2024

Comments

@chipkent
Copy link
Member

I had a python session that I was using. I then tried to run a python file. VS Code correctly detected that a groovy file was being run and raised an error. Unfortunately, it also disconnected from the server. The DH server is still running fine.

image

It would be better to:

  1. raise an error on the right (like it does)
  2. Log an error (which it doesn't)
  3. Not disconnect
@chipkent chipkent added bug Something isn't working triage labels Aug 13, 2024
@chipkent chipkent mentioned this issue Aug 13, 2024
Open
@vbabich vbabich added this to the August 2024 milestone Aug 14, 2024
@vbabich vbabich removed the triage label Aug 14, 2024
@mofojed mofojed modified the milestones: August 2024, November 2024 Nov 6, 2024
@bmingles bmingles mentioned this issue Nov 13, 2024
Merged
@bmingles bmingles linked a pull request Nov 13, 2024 that will close this issue
fix: Disposal Logic + Error toast #175
Merged
bmingles added a commit that referenced this issue Nov 15, 2024
@bmingles
fix: Disposal Logic + Error toast (#175)
5d844b0 
- Cleanup panel caches on server disconnect. Should resolve [Panel list
does not reflect the current server state
#145](#145)
- Added a toast when running a script for the first time auto connects
to a server that doesn't support the language. Part of [Attempting to
run a groovy file in python results in a disconnect
#97](#97)
- Map value disposal
- Event handler disposal
- Fixed circular dependencies issue between services and util folders.
Services can now depend on utils. Utils should not depend on services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
bug Something isn't working
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

fix: Disposal Logic + Error toast deephaven/vscode-deephaven
4 participants
@bmingles @vbabich @mofojed @chipkent