Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deephaven tabs that are not active appear to be using resources #52

Closed
chipkent opened this issue Jul 16, 2024 · 1 comment · Fixed by #173
Closed

Deephaven tabs that are not active appear to be using resources #52

chipkent opened this issue Jul 16, 2024 · 1 comment · Fixed by #173
Assignees
Labels
bug Something isn't working
Milestone

Comments

@chipkent
Copy link
Member

Plugin: 1.3.0

I have been under the impression that the Web UI is smart. For example, tabs that are not on top do not update or use resources. I think they are using resources in VS Code.

from deephaven import empty_table

for i in range(100):
    print(f"Making {i}")
    a = i
    globals()[f"t{i}"] = empty_table(10).update(['X = a', 'Y = 10 * i'])
  1. connect
  2. run the code above
  3. disconnect
  4. select a tab that is not on top

That tab will render with contents in the table. Additionally, when the code is run in step 2, the top table is very slow to render.

I repeated the experiment with a dynamic table. The tables are very slow to initially render, and the data is all there when switching tabs, so I think this is not a small-static table artifact that I am seeing.

from deephaven import time_table

for i in range(100):
    print(f"Making {i}")
    a = i
    globals()[f"t{i}"] = time_table("PT1s").update(['X = a', 'Y = 10 * i'])
@chipkent chipkent added bug Something isn't working triage labels Jul 16, 2024
@vbabich
Copy link

vbabich commented Jul 24, 2024

It sounds like VSCode isn't lazy-loading tabs, we should load when the tab is selected.

@vbabich vbabich removed the triage label Jul 24, 2024
@vbabich vbabich added this to the August 2024 milestone Jul 24, 2024
@mofojed mofojed modified the milestones: August 2024, November 2024 Nov 6, 2024
@bmingles bmingles self-assigned this Nov 12, 2024
bmingles added a commit that referenced this issue Nov 13, 2024
Panels now lazy load the first time they are shown.

Can be tested using:
```python
from deephaven import time_table

simple_ticking = time_table("PT2S")

simple_ticking2 = time_table("PT2S")

simple_ticking3 = time_table("PT2S")
```

- `simple_ticking` tab should load as usual
- Clicking `simple_ticking` or `simple_ticking2` will show spinner the
first time. Switching to another tab and back again should show what is
already loaded without spinner
- Closing tabs and re-opening from `PANELS` should re-open tabs

resolves #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants