Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace internal require jsapi with @deephaven/jsapi-nodejs package #172

Merged
merged 7 commits into from
Nov 13, 2024
Merged

refactor: Replace internal require jsapi with @deephaven/jsapi-nodejs package #172

merged 7 commits into from
Nov 13, 2024

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Nov 12, 2024 •
edited
Loading

This PR replaces the internal packages/require-jsapi with external @deephaven/jsapi-nodejs package. Should be no functional changes.

@bmingles bmingles changed the title 155 replace require jsapi refactor: replace require jsapi Nov 12, 2024
@bmingles bmingles changed the base branch from main to 151-cleanup-dhc-service November 12, 2024 18:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000004:51:57
 A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅1962
should return custom settings: Empty configspassed ✅275
should return custom settings: Populated configspassed ✅116
should be able to load VSCodepassed ✅525
should only be visible when a supported file type is active: test.groovypassed ✅3216
should only be visible when a supported file type is active: test.pypassed ✅978
 A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles force-pushed the 151-cleanup-dhc-service branch from 1aa0986 to ce62ad4 Compare November 12, 2024 18:14
@bmingles bmingles force-pushed the 155-replace-require-jsapi branch from a149dcb to 31fbbc7 Compare November 12, 2024 18:16
@bmingles bmingles changed the title refactor: replace require jsapi refactor: Replace internal require jsapi with @deephaven/jsapi-nodejs package Nov 12, 2024
@bmingles bmingles force-pushed the 155-replace-require-jsapi branch from 31fbbc7 to 59de1b1 Compare November 12, 2024 21:49
Base automatically changed from 151-cleanup-dhc-service to main November 13, 2024 13:45
@bmingles bmingles force-pushed the 155-replace-require-jsapi branch from 2897a02 to b3e0372 Compare November 13, 2024 13:55
@bmingles bmingles marked this pull request as ready for review November 13, 2024 13:55
@bmingles bmingles requested a review from mofojed November 13, 2024 13:57
@bmingles bmingles merged commit 11302d2 into main Nov 13, 2024
3 checks passed
@bmingles bmingles deleted the 155-replace-require-jsapi branch November 13, 2024 15:43
@bmingles bmingles linked an issue Nov 27, 2024 that may be closed by this pull request
Replace internal require-jsapi npm package with an external one #155
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace internal require-jsapi npm package with an external one
2 participants
@bmingles @mofojed