Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel list does not reflect the current server state #145

Closed
chipkent opened this issue Sep 24, 2024 · 0 comments · Fixed by #175
Closed

Panel list does not reflect the current server state #145

chipkent opened this issue Sep 24, 2024 · 0 comments · Fixed by #175
Labels
bug Something isn't working
Milestone
November 2024

Comments

@chipkent
Copy link
Member

Panels persist over DH server restarts, but they should not. The Panels should reflect the current state of the server and not a prior state. Following the steps below will illustrate the problem. After the restart, a list of panels is present in vscode that is not on the server.

  1. Start 2 servers
  2. Run some scripts on each server
  3. Close the tabs for the servers
  4. Kill the servers
  5. Restart the servers
  6. Reconnect to the server
  7. The "Panels" in the bottom left will populate with server tables and such. Click on one.
  8. It will attempt to open the panel with a "variable not found" error.
image
@chipkent chipkent added bug Something isn't working triage labels Sep 24, 2024
@vbabich vbabich added this to the October 2024 milestone Oct 1, 2024
@vbabich vbabich removed the triage label Oct 1, 2024
@mofojed mofojed modified the milestones: October 2024, November 2024 Nov 6, 2024
@bmingles bmingles mentioned this issue Nov 13, 2024
Merged
bmingles added a commit that referenced this issue Nov 15, 2024
@bmingles
fix: Disposal Logic + Error toast (#175)
5d844b0 
- Cleanup panel caches on server disconnect. Should resolve [Panel list
does not reflect the current server state
#145](#145)
- Added a toast when running a script for the first time auto connects
to a server that doesn't support the language. Part of [Attempting to
run a groovy file in python results in a disconnect
#97](#97)
- Map value disposal
- Event handler disposal
- Fixed circular dependencies issue between services and util folders.
Services can now depend on utils. Utils should not depend on services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

fix: Disposal Logic + Error toast deephaven/vscode-deephaven
3 participants
@vbabich @mofojed @chipkent