feat: disclosure #1068
feat: disclosure #1068
Conversation
| my_disclosure_disabled = ui.disclosure( | ||
| title="Heading", panel="Content", default_expanded=True | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Add some examples using disclosure_title and disclosure_panel, showing off disclosures with different levels in the disclosure_title, and a disclosure_panel with some padding.
There was a problem hiding this comment.
Added this code snippet as an example but investigating why they all render with the same style. When inspecting the elements they are rendering as H1, H2, H3,... respectively. Style overwriting seems to be coming from elsewhere
from deephaven import ui
@ui.component
def ui_disclosure_title_levels():
return [
ui.disclosure(
ui.disclosure_title("H1", level=1),
ui.disclosure_panel("Content", margin="10px"),
),
ui.disclosure(
ui.disclosure_title("H2", level=2),
ui.disclosure_panel("Content", margin="10px"),
),
ui.disclosure(
ui.disclosure_title("H3", level=3),
ui.disclosure_panel("Content", margin="10px"),
),
ui.disclosure(
ui.disclosure_title("H4", level=4),
ui.disclosure_panel("Content", margin="10px"),
),
ui.disclosure(
ui.disclosure_title("H5", level=5),
ui.disclosure_panel("Content", margin="10px"),
),
ui.disclosure(
ui.disclosure_title("H6", level=6),
ui.disclosure_panel("Content", margin="10px"),
),
]
my_disclosure_title_levels = ui_disclosure_title_levels()
There was a problem hiding this comment.
Hmm it looks like that's actually an issue in React spectrum.
In which case, remove this example, don't bother mentioning level, create a follow up ticket that tracks a ticket I filed against React-spectrum: adobe/react-spectrum#7671
| my_disclosure_disabled = ui.disclosure( | ||
| title="Heading", panel="Content", default_expanded=True | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Hmm it looks like that's actually an issue in React spectrum.
In which case, remove this example, don't bother mentioning level, create a follow up ticket that tracks a ticket I filed against React-spectrum: adobe/react-spectrum#7671
Closes #1037
Web-client-ui PR that exports Accordion and Disclosure is merged. Not sure if it was already a part of the release though