Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui.breadcrumbs #1094

Merged
merged 8 commits into from
Jan 29, 2025
Merged

feat: ui.breadcrumbs #1094

merged 8 commits into from
Jan 29, 2025

Conversation

ericlln
Copy link
Contributor

@ericlln ericlln commented Jan 22, 2025

Closes #859 and #1036

@ericlln ericlln requested a review from mofojed January 22, 2025 19:22
@ericlln ericlln self-assigned this Jan 22, 2025
@ericlln ericlln linked an issue Jan 22, 2025 that may be closed by this pull request
ui.breadcrumbs #1036
Closed
mofojed
mofojed approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

plugins/ui/docs/components/breadcrumbs.md Outdated Show resolved Hide resolved
mofojed
mofojed previously approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ericlln ericlln marked this pull request as ready for review January 24, 2025 22:48
@ericlln ericlln marked this pull request as draft January 24, 2025 22:51
@ericlln ericlln marked this pull request as ready for review January 27, 2025 21:49
@ericlln ericlln requested a review from mofojed January 27, 2025 21:49
mofojed
mofojed requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example looks great, just a suggestion to read from the table instead of hardcoding constants.

plugins/ui/docs/components/breadcrumbs.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/breadcrumbs.md Outdated Show resolved Hide resolved
@ericlln ericlln requested a review from mofojed January 29, 2025 15:21
mofojed
mofojed approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ericlln ericlln merged commit 312af69 into deephaven:main Jan 29, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

@margaretkennedy margaretkennedy Awaiting requested review from margaretkennedy

Assignees

@ericlln ericlln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.breadcrumbs docs: ui.breadcrumbs
2 participants
@ericlln @mofojed