Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parallel Where should not NPE on a Big TableUpdate With Both Adds and Mods #5961

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: Parallel Where should not NPE on a Big TableUpdate With Both Adds and Mods #5961

merged 2 commits into from
Aug 21, 2024

Conversation

nbauernfeind
Copy link
Member

@nbauernfeind nbauernfeind commented Aug 21, 2024 •
edited
Loading

Fixes #5960.

@nbauernfeind nbauernfeind added bug Something isn't working core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed point_release_candidate labels Aug 21, 2024
@nbauernfeind nbauernfeind self-assigned this Aug 21, 2024
@cpwright
Copy link
Contributor

You can probably add a simple unit test to cover these cases.

@nbauernfeind nbauernfeind enabled auto-merge (squash) August 21, 2024 20:17
@nbauernfeind nbauernfeind merged commit 76f27be into deephaven:main Aug 21, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright approved these changes

@lbooker42 lbooker42 Awaiting requested review from lbooker42

@rcaudy rcaudy Awaiting requested review from rcaudy

@devinrsmith devinrsmith Awaiting requested review from devinrsmith

Assignees

@nbauernfeind nbauernfeind

Labels
bug Something isn't working core Core development tasks NoDocumentationNeeded point_release_candidate ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallel Where may NPE if a Large Table Modification has Both Adds and Mods
2 participants
@nbauernfeind @cpwright