multi: check for used addresses #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Feb 7, 2024
Collaborator
|
Needs rebase. |
JoeGruffins
approved these changes
Apr 3, 2025
JoeGruffins
reviewed
Apr 3, 2025
Comment on lines
+4022
to
+4027
| na, ok := w.Wallet.(asset.NewAddresser) | ||
| if !ok { | ||
| return false, errors.New("wallet is not a NewAddresser") | ||
| } | ||
|
|
||
| return na.AddressUsed(addr) |
Member
There was a problem hiding this comment.
nit: Other functions of this kind are methods on *xcWallet in wallet.go
martonp
pushed a commit
to martonp/dcrdex
that referenced
this pull request
May 7, 2025
* check for used addresses * fix docstring and check for wallet trait on tx * add dcr recipient and mempool txs
martonp
pushed a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
* check for used addresses * fix docstring and check for wallet trait on tx * add dcr recipient and mempool txs
buck54321
added a commit
that referenced
this pull request
Jul 26, 2025
* check for used addresses * fix docstring and check for wallet trait on tx * add dcr recipient and mempool txs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2662
Alternative to #2685
Marks used addresses. Doesn't show tx info on the deposit form, but does show the used address indicator when the tx is seen.