fix(Image):if multiple iamges with same name take the newest

Author: dweinholz

simple_vm_client/openstack_connector/openstack_connector.py

@@ -25,6 +25,7 @@
 from openstack.compute.v2.server import Server
 from openstack.exceptions import (
     ConflictException,
+    DuplicateResource,
     OpenStackCloudException,
     ResourceFailure,
     ResourceNotFound,
@@ -679,6 +680,15 @@ def get_active_image_by_os_version_and_slurm_version(
 
         return backup_image
 
+    def _get_newest_image(self, images: list[Image]) -> Image:
+        """Return the newest image from a list based on created_at timestamp."""
+        if not images:
+            raise ImageNotFoundException(
+                message="No images provided to _get_newest_image",
+                name_or_id="unknown",
+            )
+        return max(images, key=lambda img: img.created_at)
+
     def get_image(
         self,
         name_or_id: str,
@@ -691,7 +701,29 @@ def get_image(
 
         logger.info(f"Get Image {name_or_id}")
 
-        image: Image | None = self.openstack_connection.get_image(name_or_id=name_or_id)
+        try:
+            image = self.openstack_connection.get_image(name_or_id=name_or_id)
+        except DuplicateResource:
+            logger.warning(
+                f"Multiple images found with name '{name_or_id}'. "
+                "Fetching all images and filtering manually to select the newest one."
+            )
+            # In newest openstacksdk, list_images() has no name filter — must filter manually
+            all_images = list(self.openstack_connection.list_images())
+            matching_images = [img for img in all_images if img.name == name_or_id]
+
+            if not matching_images:
+                logger.error(
+                    f"Unexpected: No images found matching name '{name_or_id}' after listing all images, "
+                    "despite DuplicateResource being raised. This may indicate a race condition or SDK inconsistency."
+                )
+                image = None
+            else:
+                logger.info(
+                    f"Found {len(matching_images)} image(s) with name '{name_or_id}'. "
+                    "Selecting the newest one based on created_at."
+                )
+                image = self._get_newest_image(matching_images)
 
         # --- Image not found ---
         if image is None: