Report string errors properly

dduan · dduan · commit 69ec676c122c · 2025-12-30T13:27:21.000-08:00
diff --git a/Sources/TOMLDecoder/Parsing/Parser.swift b/Sources/TOMLDecoder/Parsing/Parser.swift
@@ -1100,7 +1100,6 @@ extension Token {
         var index = text.lowerBound
         var endIndex = text.upperBound
 
-        assert(quoteChar == CodeUnits.doubleQuote || quoteChar == CodeUnits.singleQuote)
 
         if endIndex - index >= 3 && bytes[index] == CodeUnits.doubleQuote && bytes[index + 1] == CodeUnits.doubleQuote && bytes[index + 2] == CodeUnits.doubleQuote ||
             endIndex - index >= 3 && bytes[index] == CodeUnits.singleQuote && bytes[index + 1] == CodeUnits.singleQuote && bytes[index + 2] == CodeUnits.singleQuote
@@ -1117,7 +1116,7 @@ extension Token {
         } else {
             index = index + 1
             endIndex = endIndex - 1
-            guard bytes[endIndex] == quoteChar else {
+            guard endIndex >= 0, bytes[endIndex] == quoteChar else {
                 throw TOMLError(.invalidString(context: context, lineNumber: lineNumber, reason: "missing closing quote"))
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -1100,7 +1100,6 @@ extension Token {`
`1100`	`1100`	`var index = text.lowerBound`
`1101`	`1101`	`var endIndex = text.upperBound`
`1102`	`1102`
`1103`		`- assert(quoteChar == CodeUnits.doubleQuote \|\| quoteChar == CodeUnits.singleQuote)`
`1104`	`1103`
`1105`	`1104`	`if endIndex - index >= 3 && bytes[index] == CodeUnits.doubleQuote && bytes[index + 1] == CodeUnits.doubleQuote && bytes[index + 2] == CodeUnits.doubleQuote \|\|`
`1106`	`1105`	`endIndex - index >= 3 && bytes[index] == CodeUnits.singleQuote && bytes[index + 1] == CodeUnits.singleQuote && bytes[index + 2] == CodeUnits.singleQuote`
`@@ -1117,7 +1116,7 @@ extension Token {`
`1117`	`1116`	`} else {`
`1118`	`1117`	`index = index + 1`
`1119`	`1118`	`endIndex = endIndex - 1`
`1120`		`- guard bytes[endIndex] == quoteChar else {`
	`1119`	`+ guard endIndex >= 0, bytes[endIndex] == quoteChar else {`
`1121`	`1120`	`throw TOMLError(.invalidString(context: context, lineNumber: lineNumber, reason: "missing closing quote"))`
`1122`	`1121`	`}`
`1123`	`1122`	`}`