Skip to content

Commit ce69968

Browse files
authored
Add optional --redis-tag flag, fixes #1 (#24)
1 parent cb16896 commit ce69968

File tree

3 files changed

+29
-9
lines changed

3 files changed

+29
-9
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ This repository allows you to quickly install Redis into a [DDEV](https://ddev.r
99
1. `ddev get ddev/ddev-redis`
1010
2. `ddev restart`
1111

12+
With DDEV v1.23.5+ you can choose a different Redis tag, the command below creates a `.ddev/.env.redis` file that you can commit:
13+
14+
1. `ddev dotenv set .ddev/.env.redis --redis-tag 7`
15+
2. `ddev restart`
16+
1217
## Explanation
1318

1419
This Redis recipe for [DDEV](https://ddev.readthedocs.io) installs a [`.ddev/docker-compose.redis.yaml`](docker-compose.redis.yaml) using the `redis` Docker image.

docker-compose.redis.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
services:
33
redis:
44
container_name: ddev-${DDEV_SITENAME}-redis
5-
image: redis:6-bullseye
5+
image: redis:${REDIS_TAG:-6-bullseye}
66
# These labels ensure this service is discoverable by ddev.
77
labels:
88
com.ddev.site-name: ${DDEV_SITENAME}

tests/test.bats

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,44 +14,59 @@ teardown() {
1414
}
1515

1616
@test "basic installation" {
17-
ddev config --project-name=${PROJNAME} --project-type=drupal9 --docroot=web --create-docroot
17+
ddev config --project-name=${PROJNAME} --project-type=drupal --docroot=web
1818
ddev start -y
1919
cd ${TESTDIR}
20-
ddev get ${DIR}
20+
ddev add-on get ${DIR}
2121
ddev restart
2222
ddev redis-cli INFO | grep "^redis_version:6."
2323
# Check if Redis configuration was setup.
2424
[ -f web/sites/default/settings.ddev.redis.php ]
2525
grep -F 'settings.ddev.redis.php' web/sites/default/settings.php
2626
}
2727

28+
@test "basic installation with Redis tag 7" {
29+
ddev config --project-name=${PROJNAME} --project-type=drupal --docroot=web
30+
ddev start -y
31+
cd ${TESTDIR}
32+
ddev add-on get ${DIR}
33+
ddev dotenv set .ddev/.env.redis --redis-tag=7
34+
# Check if .env file for Redis exists.
35+
[ -f .ddev/.env.redis ]
36+
ddev restart
37+
ddev redis-cli INFO | grep "^redis_version:7."
38+
# Check if Redis configuration was setup.
39+
[ -f web/sites/default/settings.ddev.redis.php ]
40+
grep -F 'settings.ddev.redis.php' web/sites/default/settings.php
41+
}
42+
2843
@test "non-Drupal installation" {
29-
ddev config --project-name=${PROJNAME} --project-type=laravel --docroot=web --create-docroot
44+
ddev config --project-name=${PROJNAME} --project-type=laravel --docroot=web
3045
ddev start -y
3146
cd ${TESTDIR}
32-
ddev get ${DIR}
47+
ddev add-on get ${DIR}
3348
ddev restart
3449
ddev redis-cli INFO | grep "^redis_version:6."
3550
# Drupal configuration should not be present
3651
[ ! -f web/sites/default/settings.ddev.redis.php ]
3752
}
3853

3954
@test "Drupal 7 installation" {
40-
ddev config --project-name=${PROJNAME} --project-type=drupal7 --docroot=web --create-docroot
55+
ddev config --project-name=${PROJNAME} --project-type=drupal7 --docroot=web
4156
ddev start -y
4257
cd ${TESTDIR}
43-
ddev get ${DIR}
58+
ddev add-on get ${DIR}
4459
ddev restart
4560
ddev redis-cli INFO | grep "^redis_version:6."
4661
# Drupal configuration should not be present
4762
[ ! -f web/sites/default/settings.ddev.redis.php ]
4863
}
4964

5065
@test "Drupal 9 installation without settings management" {
51-
ddev config --project-name=${PROJNAME} --disable-settings-management --project-type=drupal9 --docroot=web --create-docroot
66+
ddev config --project-name=${PROJNAME} --disable-settings-management --project-type=drupal --docroot=web
5267
ddev start -y
5368
cd ${TESTDIR}
54-
ddev get ${DIR}
69+
ddev add-on get ${DIR}
5570
ddev restart
5671
ddev redis-cli INFO | grep "^redis_version:6."
5772
# Drupal configuration should not be present

0 commit comments

Comments
 (0)