New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"test" and "ci" should have their own environment #25

Open

ddahan opened this issue Dec 21, 2024 · 0 comments

Owner

ddahan commented Dec 21, 2024

Currently we're using env overriding when running pytest (in pyproject.toml). Here are the potential issues:
- Env overriding is not very clean as "test" and "ci" don't have their own environment.
- It's very confusing to set up and could lead to unexpected errors.
- CI overriding makes no sense as there should be only one db, not two like in local.
- It's not 12factors compliant as config is in code
- We could technically erase prod database in some circumstances

ddahan added this to Fast-batteries Public Roadmap

ddahan moved this to Backlog in Fast-batteries Public Roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment