General: Various fixes to the correctness of code and documentation reported by PHPStan.

Props justlevine

See #63268

git-svn-id: https://develop.svn.wordpress.org/trunk@60275 602fd350-edb4-49c9-b593-d223f7449a82

Author: johnbillion

src/wp-admin/includes/class-language-pack-upgrader.php

@@ -383,7 +383,7 @@ public function get_name_for_update( $update ) {
 			case 'theme':
 				$theme = wp_get_theme( $update->slug );
 				if ( $theme->exists() ) {
-					return $theme->Get( 'Name' );
+					return $theme->get( 'Name' );
 				}
 				break;
 			case 'plugin':

src/wp-admin/includes/class-wp-automatic-updater.php

@@ -411,7 +411,7 @@ public function update( $type, $item ) {
 			case 'theme':
 				$upgrader_item = $item->theme;
 				$theme         = wp_get_theme( $upgrader_item );
-				$item_name     = $theme->Get( 'Name' );
+				$item_name     = $theme->get( 'Name' );
 				// Add the current version so that it can be reported in the notification email.
 				$item->current_version = $theme->get( 'Version' );
 				if ( empty( $item->current_version ) ) {

src/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -77,7 +77,7 @@ public function connect() {
 			return false;
 		}
 
-		$this->ftp->setTimeout( FS_CONNECT_TIMEOUT );
+		$this->ftp->SetTimeout( FS_CONNECT_TIMEOUT );
 
 		if ( ! $this->ftp->SetServer( $this->options['hostname'], $this->options['port'] ) ) {
 			$this->errors->add(
@@ -120,7 +120,7 @@ public function connect() {
 
 		$this->ftp->SetType( FTP_BINARY );
 		$this->ftp->Passive( true );
-		$this->ftp->setTimeout( FS_TIMEOUT );
+		$this->ftp->SetTimeout( FS_TIMEOUT );
 
 		return true;
 	}

src/wp-admin/includes/post.php

@@ -2186,7 +2186,7 @@ function wp_autosave( $post_data ) {
  *
  * @param int $post_id Optional. Post ID.
  */
-function redirect_post( $post_id = '' ) {
+function redirect_post( $post_id = 0 ) {
 	if ( isset( $_POST['save'] ) || isset( $_POST['publish'] ) ) {
 		$status = get_post_status( $post_id );
 

src/wp-admin/includes/taxonomy.php

@@ -75,7 +75,7 @@ function wp_create_category( $cat_name, $category_parent = 0 ) {
  * @param int      $post_id    Optional. The post ID. Default empty.
  * @return int[] Array of IDs of categories assigned to the given post.
  */
-function wp_create_categories( $categories, $post_id = '' ) {
+function wp_create_categories( $categories, $post_id = 0 ) {
 	$cat_ids = array();
 	foreach ( $categories as $category ) {
 		$id = category_exists( $category );

src/wp-includes/block-template.php

@@ -253,7 +253,7 @@ function get_the_block_template_html() {
 		if ( is_user_logged_in() ) {
 			return '<h1>' . esc_html__( 'No matching template found' ) . '</h1>';
 		}
-		return;
+		return '';
 	}
 
 	$content = $wp_embed->run_shortcode( $_wp_current_template_content );

src/wp-includes/category-template.php

@@ -793,7 +793,7 @@ function wp_tag_cloud( $args = '' ) {
  * @return int Scaled count.
  */
 function default_topic_count_scale( $count ) {
-	return round( log10( $count + 1 ) * 100 );
+	return (int) round( log10( $count + 1 ) * 100 );
 }
 
 /**

src/wp-includes/class-wp-block-pattern-categories-registry.php

@@ -107,7 +107,7 @@ public function unregister( $category_name ) {
 	 * @since 5.5.0
 	 *
 	 * @param string $category_name Pattern category name including namespace.
-	 * @return array Registered pattern properties.
+	 * @return array|null Registered pattern properties, or `null` if the pattern category is not registered.
 	 */
 	public function get_registered( $category_name ) {
 		if ( ! $this->is_registered( $category_name ) ) {

src/wp-includes/class-wp-block-patterns-registry.php

@@ -188,7 +188,7 @@ private function get_content( $pattern_name, $outside_init_only = false ) {
 	 * @since 5.5.0
 	 *
 	 * @param string $pattern_name Block pattern name including namespace.
-	 * @return array Registered pattern properties.
+	 * @return array|null Registered pattern properties or `null` if the pattern is not registered.
 	 */
 	public function get_registered( $pattern_name ) {
 		if ( ! $this->is_registered( $pattern_name ) ) {

src/wp-includes/class-wp-block-styles-registry.php

@@ -140,7 +140,7 @@ public function unregister( $block_name, $block_style_name ) {
 	 *
 	 * @param string $block_name       Block type name including namespace.
 	 * @param string $block_style_name Block style name.
-	 * @return array Registered block style properties.
+	 * @return array|null Registered block style properties or `null` if the block style is not registered.
 	 */
 	public function get_registered( $block_name, $block_style_name ) {
 		if ( ! $this->is_registered( $block_name, $block_style_name ) ) {

src/wp-includes/pluggable.php

@@ -446,10 +446,10 @@ function wp_mail( $to, $subject, $message, $headers = '', $attachments = array()
 							$phpmailer->addAddress( $address, $recipient_name );
 							break;
 						case 'cc':
-							$phpmailer->addCc( $address, $recipient_name );
+							$phpmailer->addCC( $address, $recipient_name );
 							break;
 						case 'bcc':
-							$phpmailer->addBcc( $address, $recipient_name );
+							$phpmailer->addBCC( $address, $recipient_name );
 							break;
 						case 'reply_to':
 							$phpmailer->addReplyTo( $address, $recipient_name );

src/wp-includes/script-loader.php

@@ -396,7 +396,7 @@ function wp_default_packages_inline_scripts( $scripts ) {
 			"\n",
 			array(
 				'( function() {',
-				'	var userId = ' . get_current_user_ID() . ';',
+				'	var userId = ' . get_current_user_id() . ';',
 				'	var storageKey = "WP_DATA_USER_" + userId;',
 				'	wp.data',
 				'		.use( wp.data.plugins.persistence, { storageKey: storageKey } );',