Tank wrapping Waterfall does not close

[snorberhuis]

In my integration tests I am using a tank something like this:

tank : Tank
constructor(url){
this.tank = new Tank(new Waterfall(url));
}

If I call this.tank.close() my tests do not stop. Switching to only a Waterfall immediatly fixes this issue:

tank : Waterfall
constructor(url){
this.tank = new Waterfall(url);
}

Something seems to stop the tank from closing correctly. Any ideas on how I can provide more details?

[dcharbonnier]

You should always keep a reference to your "root" connection to close it, I tank could be connected to a more complicated pipeline and closing a "branch" does not means you want to close everything.
In your case closing the Waterfall is enough but you may even need to close both in some cases.
For now the tank is not able to change the underlying connection that could be a good enhancement and in this case closing the tank should not close the underlying connection, so the current API is the most flexible IMO.

[snorberhuis]

Thanks for the clarification. You could add this to the documentation. The documentation on the Shell.close method does not document the fail conditions.