Skip to content

Fix compilation errors in SponsorBlock and VolumeBar #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix compilation errors in SponsorBlock and VolumeBar #373

wants to merge 4 commits into from

Conversation

@cwsteini
Copy link

@cwsteini cwsteini commented Oct 1, 2025 

 This PR fixes two compilation errors:
 
 ## SponsorBlock.xm
 - Fixed method calls: Changed `self.currentVideoID` to `[self currentVideoID]`
 - Fixed method calls: Changed `self.currentVideoMediaTime` to `[self currentVideoMediaTime]`
 - Removed redundant property declaration
 - Fixed validation check for sponsorBlockValues
 
 ## VolumeBar.xm  
 - Replaced static variable initialization with runtime function
 - Changed `static BOOL volumeBar = ...` to `shouldShowVolumeBar()` function
 
 These changes should resolve the build failures mentioned in the original issue.

@cwsteini
Update SponsorBlock.xm
9671d04 
Fix SponsorBlock compilation errors: correct method calls and remove redundant property declaration
@cwsteini
Fix VolumeBar compilation error: replace static variable initializati…
9ad6770 
…on with runtime function

Replace problematic static BOOL volumeBar initialization with shouldShowVolumeBar() function to avoid compile-time initialization of runtime values
@cwsteini
Fix SelectableLyrics compilation error: remove duplicate property dec…
c52d805 
…laration and fix static variable initialization

Fix compilation errors in SelectableLyrics.xm:

## Issues Fixed:
- **Duplicate property declaration**: Removed redundant `%property (retain, nonatomic) UITextView *lyrics;` from Logos hook since property is already declared in @interface
- **Static variable initialization**: Replaced `static BOOL selectableLyrics = YTMU(...)` with `shouldShowSelectableLyrics()` function to avoid compile-time initialization of runtime values

## Changes:
- Removed duplicate property declaration from %hook
- Changed static variable to runtime function
- Updated all references from `selectableLyrics` to `shouldShowSelectableLyrics()`

This resolves the compilation error that was preventing the build from completing.
@cwsteini
Fix VolumeBar VLA compilation error: remove duplicate property declar…
c91ce54 
…ation

Remove redundant %property declaration from VolumeBar.xm that was causing Logos preprocessor to generate variable-length array code with non-const variables.

The property is already declared in the @interface, so the %property declaration was unnecessary and causing compilation errors with VLA extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cwsteini