Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No trace no more #2

Closed
arichiardi opened this issue Apr 4, 2016 · 6 comments
Closed

No trace no more #2

arichiardi opened this issue Apr 4, 2016 · 6 comments

Comments

@arichiardi
Copy link
Contributor

I was using this library with success in lein, switching to boot muted the tracing.
I am not even sure that the lein to boot passage is related, but basically after a bit of debugging I see that js/clairvoyant.core.devmode is always false no matter what :elide-asserts is.

I wanted to dig more and I migth be blind but I cannot really find where clairvoyant.core/devmode is defined in the code source.

I need some little hint 😄

@arichiardi
Copy link
Contributor Author

By the way I found a workaround, and I don't think boot is related, there must be some other problem with the google define you have in your code (line 80 of core.clj, I went through my .m2):

I added: :closure-defines {"clairvoyant.core.devmode" true}

@danielcompton
Copy link

That's not a workaround, that's expected behaviour :). You need to provide a closure-define to enable/disable it IIRC.

@arichiardi
Copy link
Contributor Author

Oh, but the pure clairvoyant is supposed to enable/disable itself on :elide-assert that's why I reported it...Maybe we just need a note in the README?

@mike-thompson-day8
Copy link

@arichiardi we provided the original patch to clairvoyant so it would use :elide-assert but then we backed away from that method and suggested using goog defines instead (it was a new feature at that time). But our patch appears stuck, which is one reason why we have our own fork
spellhouse/clairvoyant#14

But the bottom line is that our fork is subtly different on that point. And, sorry, you are right that a note in the README would be a good idea.

@arichiardi
Copy link
Contributor Author

Oh (#2), sorry about the noise guys, I was a bit out of the loop on this. Of course it explains everything and thanks for clarifying it. I will add the note.

@mike-thompson-day8
Copy link

Thanks for pointing this out and improving the README.

We've improved the originating docs too.
https://github.com/Day8/re-frame/wiki/Debugging#dev-vs-prod---important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants