Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedell comments on document #1

Open
5 tasks
davidwhogg opened this issue Sep 29, 2016 · 2 comments
Open
5 tasks

Bedell comments on document #1

davidwhogg opened this issue Sep 29, 2016 · 2 comments
Assignees

Comments

@davidwhogg
Copy link
Owner

  • bullet point about sparseness on page 3: I would change the last sentence to "we expect only a few, isolated lines to participate in (say) a given component of the surface-velocity-related distortion" because we definitely wouldn't expect ALL basis functions for surface-velocity effects to be isolated to a few wavelengths - something like convective blueshift will distort/change all the line profiles the same way to first order.
  • L and T are not defined for the summations in equations 5, 6, 9 (on purpose? how do we define those anyway - arbitrary choice?)
  • b_l not defined in equation 6
  • for "systematics" (equation 9), are those meant to be instrumental or continuum normalization-related in origin? If so, shouldn't it be a function of plain wavelength, not stellar rest-frame wavelength?
  • I'd also like to propose that the logo of Avast be a cartoon star wearing an eyepatch. (get it? because it's like a pirate but also like a starspot??)
@davidwhogg davidwhogg self-assigned this Sep 29, 2016
@davidwhogg
Copy link
Owner Author

Note to self: Am I clear about whether we are rest-frame for wavelength or what?

@davidwhogg
Copy link
Owner Author

I am delaying on these while we write the spectral variability paper first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant