chore: increase merge suggestion stale re-run interval from 1h to 24h#9
Merged
Conversation
The hourly stale re-run adds little value: all person-modifying operations (merge, split, move_faces, category change, detection, recluster) already call MarkDirty immediately, so re-running on unchanged data produces identical suggestions. The DirtyGeneration fix (PR #8) also closed the race condition where a concurrent MarkDirty could be silently lost. 24h is a more appropriate fallback interval — pure safety net for edge cases like a missed MarkDirty trigger, not a primary discovery mechanism. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultMergeSuggestionStaleSeconds3600 → 86400（1小时 → 24小时）RunBackgroundSlice中staleSeconds <= 0时的硬编码兜底值Why
每小时自动重跑意义很小：所有修改人物数据的操作都有对应
MarkDirty触发，数据不变时重跑结果完全相同。PR #8 的DirtyGeneration修复已解决并发 MarkDirty 被静默丢失的问题。24小时作为纯兜底手段更合理。🤖 Generated with Claude Code