Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing placement of fins causes them to jump to strange places after copying a fin object #65

Open
livetoski78 opened this issue Nov 25, 2023 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@livetoski78
Copy link

livetoski78 commented Nov 25, 2023

Expected: After making multiple copies of a fin object, I should be able to rotate them and move them around.

Actual: Rotating or moving a copied fin causes the fin objects to be moved to strange places.

Steps to reproduce:

  1. Create a body tube
  2. Create a single fin
  3. Place it where you want it to be on a body tube
  4. Duplicate or copy/paste the fin
  5. Go to placement and select the "X" axis and "Apply incremental changes"
  6. Select and angle, e.g. 120
  7. Click "Ok" and notice the fin jumps position
    fin_error_1
    fin_error_2
    fin_error_3
@davesrocketshop
Copy link
Owner

Not surprised by this which is probably not what you expected to hear. Let me explain why.

The fin is offset from the origin by the radius of the body tube. Even when not using the rocket builder there's an offset (this probably shouldn't be the case. I'll have to check to see what would be involved with a fix) Rotating a fin is really rotating it around the base + offset, In your context that offset is undefined. Even in the context of the rocket builder which is aware of the body tube diameter, rotation is not straight forward.

What "should" happen, which is also not what you want, is the fin rotation angle is the rotation angle from the base. You would still need to calculate an appropriate X and Y offset.

Let me look at appropriate solutions, but it won't be using the placement UI as you do in the second image, but setting appropriate property values as in the third image, or through the component UI. You would set the rotation angle there

@davesrocketshop davesrocketshop self-assigned this Nov 25, 2023
@davesrocketshop davesrocketshop added bug Something isn't working enhancement New feature or request labels Nov 25, 2023
@livetoski78
Copy link
Author

livetoski78 commented Nov 25, 2023 via email

@davesrocketshop
Copy link
Owner

That makes sense. Let me look into it. It may not be a simple reversion as there were a lot of changes to support the rocket builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants