Issue with vimeo embeds

[Snakeman]

hi,

the new version of fitvids ignore the maxium size for vimeo videos

can see it here http://www.nils-snake.de/archives/hunde-schuetteln-sich-in-zeitlupe or here http://www.nils-snake.de/page/10

hope there comes a fix for it

regards

[davatron5000]

I probably won't be able to look at it or do anything until Monday. 

Can you paste your embed code here?
—
Sent from Mailbox for iPhone

On Sat, Apr 5, 2014 at 3:25 AM, Snakeman [email protected] wrote:

hi,
the new version of fitvids ignore the maxium size for vimeo videos
can see it here http://www.nils-snake.de/archives/hunde-schuetteln-sich-in-zeitlupe or here http://www.nils-snake.de/page/10
hope there comes a fix for it

regards

Reply to this email directly or view it on GitHub:
#167

[Snakeman]

there is no embed code - i used the automatically embed from wordpress jetpack - http://jetpack.me/support/shortcode-embeds/

[kenhowardpdx]

Hey @Snakeman!

I'm trying to understand the problem. Are you expecting the width and height attributes to inform fitvids the maximum dimensions of the object?

Your example:

<iframe
    src="//player.vimeo.com/video/77111226" width="840" height="473" frameborder="0" title="SHAKE" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>

Would this mean you DO NOT want the video to exceed 840px wide and 473px tall?

[Snakeman]

Exactly!

[davatron5000]

@Snakeman, I think you might be confused on what FitVids does exactly. It never had that functionality so there is no regression. But I understand what you're getting at and we can merge this into #19.