bug(tooling-core): createTransformProcessor check-mode detection never fires for plain RunConfig callers

[datalackey]

Summary

createTransformProcessor detects check mode via config.check === true (an optional boolean on a locally-extended type), not via config.runMode === "check" (the framework standard).

A caller passing a plain RunConfig — which has runMode but no check field — will never trigger check mode through this helper. The file will be written even when the runner is in "check" mode.

Affected file

• javascript/tooling-core/src/repository/createTransformProcessor.ts:6,18

Correct pattern (used everywhere else)

if (config.runMode === "check") { ... }

See RepositoryRunner.ts:87 for the canonical usage.

Fix

Replace config.check === true with config.runMode === "check" in createTransformProcessor.ts. Remove the check?: boolean extension from the TConfig constraint if it is no longer needed.

[datalackey]

Related inconsistent-pattern context: the root cause of this bug is that createTransformProcessor uses a second check-mode detection mechanism — a locally-extended check?: boolean field on TConfig — rather than the framework-standard config.runMode === "check" used everywhere else (RepositoryRunner.ts:87, all real plugins).

So fixing this ticket also closes the broader inconsistency: after the fix, runMode: "check" should be the single canonical check-mode signal across the entire codebase.