Allow Orcid IDs/URLs to have been issued from the sandbox

Author: paulalden

lib/bolognese/utils.rb

@@ -574,7 +574,7 @@ def orcid_as_url(orcid)
     end
 
     def validate_orcid(orcid)
-      orcid = Array(/\A(?:(http|https):\/\/(www\.)?orcid\.org\/)?(\d{4}[[:space:]-]\d{4}[[:space:]-]\d{4}[[:space:]-]\d{3}[0-9X]+)\z/.match(orcid)).last
+      orcid = Array(/\A(?:(?:http|https):\/\/(?:(?:www|sandbox)?\.)?orcid\.org\/)?(\d{4}[[:space:]-]\d{4}[[:space:]-]\d{4}[[:space:]-]\d{3}[0-9X]+)\z/.match(orcid)).last
       orcid.gsub(/[[:space:]]/, "-") if orcid.present?
     end
 

spec/utils_spec.rb

@@ -64,6 +64,18 @@
       expect(response).to eq("0000-0002-1394-3097")
     end
 
+    it "validate_orcid sandbox" do
+      orcid = "http://sandbox.orcid.org/0000-0002-2590-225X"
+      response = subject.validate_orcid(orcid)
+      expect(response).to eq("0000-0002-2590-225X")
+    end
+
+    it "validate_orcid sandbox https" do
+      orcid = "https://sandbox.orcid.org/0000-0002-2590-225X"
+      response = subject.validate_orcid(orcid)
+      expect(response).to eq("0000-0002-2590-225X")
+    end
+
     it "validate_orcid wrong id" do
       orcid = "0000-0002-1394-309"
       response = subject.validate_orcid(orcid)