New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Mark ignored for label having empty payload CID #39

Open

xinaxu opened this issue Sep 26, 2023 · 0 comments

Labels

bug

Contributor

xinaxu commented Sep 26, 2023

https://filfox.info/en/message/bafy2bzaceaaqqdpd3jb37trowkjwhi4w7eeb4ax5uzddkahvpseilhq3thbxm?t=4
This deal was sent with an empty Payload CID.
It's marked as IndexedAndAnnounced but I cannot find it on cid.contact
Should I regard this deal as 'unretrievable'?

The retrieval bot currently relies on the label field as payload CID. It's documented here. https://raw.githubusercontent.com/data-preservation-programs/singularity/main/docs/swagger/swagger.yaml
There is no simple way to get the payload CID from the pieceCID.
In RetrievalBot V2, this problem is addressed by Riba's algorithm - https://github.com/data-preservation-programs/RetrievalBot/blob/main/filplus.md#piece-range-retrieval
Finally, here the action item could be, if the root CID is an empty CID (bafyaaaa), then mark it as ignored.

xinaxu added the bug label

xinaxu added this to ActionArena

github-project-automation bot moved this to 🍇 Backlog in ActionArena

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment