Skip to content

Commit 1c0bfe5

Browse files
committed
address review comments
1 parent 2284f2d commit 1c0bfe5

File tree

4 files changed

+9
-2
lines changed

4 files changed

+9
-2
lines changed

cloudsql-mysql-plugin/src/e2e-test/resources/errorMessage.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
errorMessageInvalidSourceDatabase=errorMessage: SQL Exception occurred
1+
errorMessageInvalidSourceDatabase=SQL Error occurred, sqlState: '42000', errorCode: '1049'
22
errorMessageInvalidImportQuery=Import Query select must contain the string '$CONDITIONS'. if Number of Splits is not set\
33
\ to 1. Include '$CONDITIONS' in the Import Query
44
errorMessageCloudMySqlInvalidReferenceName=Invalid reference name

cloudsql-postgresql-plugin/src/e2e-test/features/source/RunTime.feature

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ Feature: CloudSQL-PostGreSQL Source - Run Time scenarios
147147
And Save and Deploy Pipeline
148148
And Run the Pipeline in Runtime
149149
And Wait till pipeline is in running state
150+
And Open and capture logs
150151
And Verify the pipeline status is "Failed"
152+
And Close the pipeline logs
151153
Then Open Pipeline logs and verify Log entries having below listed Level and Message:
152154
| Level | Message |
153155
| ERROR | errorLogsMessageInvalidBoundingQuery |
@@ -189,6 +191,7 @@ Feature: CloudSQL-PostGreSQL Source - Run Time scenarios
189191
Then Save the pipeline
190192
Then Preview and run the pipeline
191193
Then Wait till pipeline preview is in running state and check if any error occurs
194+
Then Open and capture pipeline preview logs
192195
Then Verify the preview run status of pipeline in the logs is "failed"
193196

194197
@CLOUDSQLPOSTGRESQL_SOURCE_TEST @CLOUDSQLPOSTGRESQL_TARGET_TEST

mssql-plugin/src/e2e-test/features/mssql/mssql source/RunTimeWithMacros.feature

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,9 @@ Feature: Mssql Source - Run time scenarios (macro)
249249
And Enter runtime argument value "invalidSelectQuery" for key "importQuery"
250250
And Run the Pipeline in Runtime with runtime arguments
251251
Then Wait till pipeline is in running state
252+
And Open and capture logs
252253
And Verify the pipeline status is "Failed"
254+
And Close the pipeline logs
253255
Then Open Pipeline logs and verify Log entries having below listed Level and Message:
254256
| Level | Message |
255257
| ERROR | errorMessageInvalidsourcetable |
@@ -294,7 +296,9 @@ Feature: Mssql Source - Run time scenarios (macro)
294296
And Enter runtime argument value "invalid.password" for key "Password"
295297
And Run the Pipeline in Runtime with runtime arguments
296298
Then Wait till pipeline is in running state
299+
And Open and capture logs
297300
And Verify the pipeline status is "Failed"
301+
And Close the pipeline logs
298302
Then Open Pipeline logs and verify Log entries having below listed Level and Message:
299303
| Level | Message |
300304
| ERROR | errorMessageInvalidCredentialSource |

oracle-plugin/src/e2e-test/resources/errorMessage.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ errorMessageInvalidImportQuery=Import Query select must contain the string '$CON
1212
\ to 1. Include '$CONDITIONS' in the Import Query
1313
errorMessageBlankUsername=Username is required when password is given.
1414
errorMessageInvalidTableName=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002', errorMessage: SQL Exception occurred: [Message='IO Error: Unknown host specified ', SQLState='08006', ErrorCode='17002'].'
15-
errorMessageInvalidSinkDatabase=errorMessage: SQL Exception occurred
15+
errorMessageInvalidSinkDatabase=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002'
1616
errorMessageInvalidHost=Error encountered while configuring the stage: 'SQL Error occurred, sqlState: '08006', errorCode: '17002', errorMessage: SQL Exception occurred: [Message='IO Error: Unknown host specified ', SQLState='08006', ErrorCode='17002'].'
1717
errorLogsMessageInvalidBoundingQuery=Spark program 'phase-1' failed with error: Stage 'Oracle' encountered : \
1818
java.io.IOException: ORA-00936: missing expression . Please check the system logs for more details.

0 commit comments

Comments
 (0)