Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Glue db validation incorrect #1776

Open
TejasRGitHub opened this issue Mar 5, 2025 · 1 comment
Open

[BUG] Glue db validation incorrect #1776

TejasRGitHub opened this issue Mar 5, 2025 · 1 comment
Assignees
Labels
effort: low priority: high status: in-progress This issue has been picked and is being implemented

Comments

@TejasRGitHub
Copy link
Collaborator

Describe the bug

Unable to import a valid glue db

Image

How to Reproduce

  1. Create a glue db with "-" in it
  2. Import that S3 bucket as a dataset in data.all v2.7.0

Expected behavior

No response

Your project

No response

Screenshots

No response

OS

Mac

Python version

3.9

AWS data.all version

2.7.0-rc

Additional context

No response

@TejasRGitHub
Copy link
Collaborator Author

Glue external regex validation should contain "-" in it.

'valid_external_regex': '^[a-zA-Z0-9_]+$',

Adding a "-" in it for fixing this issue.

@dlpzx , @petrkalos , could you please lmk why are we restricting the name to this format and why are we not allowing the names which are allowed by AWS glue ?

Can't we allow all the glue databases as per the conventions allowed by glue ( e.g. - https://docs.aws.amazon.com/glue/latest/dg/aws-glue-api-catalog-databases.html )

@TejasRGitHub TejasRGitHub self-assigned this Mar 12, 2025
@TejasRGitHub TejasRGitHub added status: in-progress This issue has been picked and is being implemented priority: high effort: low labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low priority: high status: in-progress This issue has been picked and is being implemented
Projects
None yet
Development

No branches or pull requests

1 participant