Failure with released dcmodifydb and dev dbplyr

[mgirlich]

We see

• checking examples ... ERROR

  Running examples in ‘dcmodifydb-Ex.R’ failed
  The error most likely occurred in:
  
  > ### Name: is_working_db
  > ### Title: Rule check on the database
  > ### Aliases: is_working_db
  > 
  > ### ** Examples
  > 
  > person <- dbplyr::memdb_frame(age = 12, salary = 3000)
  ...
   15.               │ │     └─base (local) doTryCatch(return(expr), name, parentenv, handler)
   16.               │ └─base::withCallingHandlers(...)
   17.               └─dbplyr::partial_eval(get_expr(x), data, get_env(x), error_call = error_call)
   18.                 └─dbplyr:::partial_eval_call(call, data, env)
   19.                   └─base::lapply(call[-1], partial_eval, data = data, env = env)
   20.                     └─dbplyr (local) FUN(X[[i]], ...)
   21.                       └─dbplyr:::partial_eval_sym(call, data, env)
   22.                         └─cli::cli_abort("Object {.var {name}} not found.", call = NULL)
   23.                           └─rlang::abort(message, ..., call = call, use_cli_format = TRUE)
  Execution halted
  

• checking tests ...

    Running ‘testthat.R’
   ERROR
  Running the tests in ‘tests/testthat.R’ failed.
  Last 13 lines of output:
    • On CRAN (5)
    
    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error (test-is_working.R:27:5): is working: is working check ────────────────
    Error in `dplyr::filter(table, z > 2)`: Problem while computing `..1 = z > 2`
    Caused by error:
    ! Object `z` not found.
    ── Error (test-modify.R:96:5): modify: handles a non-working rule ──────────────
    Error in `dplyr::filter(table, y > 1)`: Problem while computing `..1 = y > 1`
    Caused by error:
    ! Object `y` not found.
    
    [ FAIL 2 | WARN 0 | SKIP 5 | PASS 34 ]
    Error: Test failures
    Execution halted
  

The problems comes from this change in dbplyr

• Variables that are neither found in the data nor in the environment now
  produce an error (@mgirlich, #907).

We plan to release dbplyr soon so it would be great if you could fix this issue.

[hadley]

dbplyr is now scheduled for release on Jan 16; please let us know if there's anything we can do to help.

[hadley]

Just a reminder that we're submitting to CRAN on Monday.