Skip to content

Commit 7855d9b

Browse files
authored
Null safety cleanup in test runner code (#2661)
1 parent 4fc5d8c commit 7855d9b

File tree

4 files changed

+2
-11
lines changed

4 files changed

+2
-11
lines changed

frontend_server_client/example/web_client.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ void main(List<String> args) async {
2727
'--multi-root-scheme=org-dartlang-sdk',
2828
'--modules=amd',
2929
'--module-name=dart_sdk',
30-
'--sound-null-safety',
3130
'-o',
3231
dartSdkJs,
3332
p.url.join(sdkDir, sdkKernelPath),

frontend_server_common/lib/src/devfs.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ class WebDevFS {
2929
required this.projectDirectory,
3030
required this.packageUriMapper,
3131
required this.index,
32-
this.soundNullSafety = true,
3332
this.urlTunneler,
3433
required this.sdkLayout,
3534
required this.compilerOptions,
@@ -46,9 +45,6 @@ class WebDevFS {
4645
List<Uri> sources = <Uri>[];
4746
DateTime? lastCompiled;
4847

49-
@Deprecated('Only sound null safety is supported as of Dart 3.0')
50-
final bool soundNullSafety;
51-
5248
final TestSdkLayout sdkLayout;
5349
final CompilerOptions compilerOptions;
5450

frontend_server_common/lib/src/frontend_server_client.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,6 @@ class ResidentCompiler {
394394
],
395395
if (useDebuggerModuleNames) '--debugger-module-names',
396396
'--experimental-emit-debug-metadata',
397-
'--sound-null-safety',
398397
for (final experiment in compilerOptions.experiments)
399398
'--enable-experiment=$experiment',
400399
if (compilerOptions.canaryFeatures) '--dartdevc-canary',

test_common/lib/test_sdk_configuration.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,8 @@ import 'package:test_common/test_sdk_layout.dart';
1414
/// Implementation for SDK configuration for tests that can generate
1515
/// missing assets.
1616
///
17-
/// - Generate SDK js, source map, and full dill (normally included in flutter
18-
/// SDK or produced by build).
19-
///
20-
/// TODO(annagrin): update to only generating missing sound artifacts
21-
/// for frontend server after we have no uses of weak null safety.
17+
/// - Generate SDK js, source map (normally included in flutter SDK
18+
/// or produced by build).
2219
class TestSdkConfigurationProvider extends SdkConfigurationProvider {
2320
final _logger = Logger('TestSdkConfigurationProvider');
2421

0 commit comments

Comments
 (0)