`pkg/dartdev/test/commands/compile_test` flaky -> RuntimeError on `unittest-asserts-release-mac-x64`

[bkonyi]

The tests

pkg/dartdev/test/commands/compile_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-mac-x64

Logs.

[bkonyi]

In particular, compile - Compile and run executable from signed dartaotruntime is failing.

It looks like the failure is caused when attempting to generate a dill file using gen_kernel_aot.dart.snapshot with a signed dartaotruntime. Running the snapshot with an unsigned runtime works, and running dartaotruntime --help does as well. However, running the AOT snapshot with the signed runtime results in the process being SIGKILL'd. Signing the AOT snapshot doesn't change anything.

Here's the output from the system logs:

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               dartaotruntime [92060]
Path:                  /Users/USER/*/dartaotruntime
Identifier:            dartaotruntime
Version:               ???
Code Type:             X86-64 (Native)
Parent Process:        dart [92059]
Responsible:           Terminal [21865]
User ID:               434811

Date/Time:             2024-04-12 10:33:53.2062 -0400
OS Version:            macOS 14.4.1 (23E224)
Report Version:        12
Bridge OS Version:     8.4 (21P4222)
Anonymous UUID:        59C62BA6-9AB3-3DB5-D0D8-D08FA20739B9

Sleep/Wake UUID:       7D6CD564-5BCB-4AB9-931B-63E614FCD9E5

Time Awake Since Boot: 200000 seconds
Time Since Wake:       2150 seconds

System Integrity Protection: enabled

Crashed Thread:        0  dart:gen_kernel_aot.dart.snapshot  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid))
Exception Codes:       UNKNOWN_0x32 at 0x0000000102405464
Exception Codes:       0x0000000000000032, 0x0000000102405464

Termination Reason:    Namespace CODESIGNING, Code 2 Invalid Page

VM Region Info: 0x102405464 is in 0x102401000-0x1029b5000;  bytes after start: 17508  bytes before end: 5962651
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      VM_ALLOCATE                 1023fe000-102401000    [   12K] rw-/rwx SM=ZER  
--->  VM_ALLOCATE                 102401000-1029b5000    [ 5840K] r-x/rwx SM=COW  
      mapped file                 1029b5000-1029b6000    [    4K] rw-/rw- SM=COW  Object_id=48e4b6a5

Thread 0 Crashed:: dart:gen_kernel_aot.dart.snapshot Dispatch queue: com.apple.main-thread
0   ???                                        0x102405464 ???
1   dartaotruntime                             0x101812fb7 0x1016c8000 + 1355703
2   dartaotruntime                             0x1018522aa 0x1016c8000 + 1614506
3   dartaotruntime                             0x10198b842 Dart_Invoke + 1346
4   dartaotruntime                             0x10196642b 0x1016c8000 + 2745387
5   dartaotruntime                             0x10196695e 0x1016c8000 + 2746718
6   dartaotruntime                             0x1016f634f 0x1016c8000 + 189263
7   dartaotruntime                             0x1016f55d0 0x1016c8000 + 185808
8   dartaotruntime                             0x1016f5117 0x1016c8000 + 184599
9   dartaotruntime                             0x1016f5d64 0x1016c8000 + 187748
10  dartaotruntime                             0x1016f500d 0x1016c8000 + 184333
11  dyld                                    0x7ff80adad366 start + 1942

Thread 1:: dart:io EventHandler
0   libsystem_kernel.dylib                  0x7ff80b0fe0ae kevent + 10
1   dartaotruntime                             0x1016fab78 0x1016c8000 + 207736
2   dartaotruntime                             0x101971143 0x1016c8000 + 2789699
3   libsystem_pthread.dylib                 0x7ff80b13918b _pthread_start + 99
4   libsystem_pthread.dylib                 0x7ff80b134ae3 thread_start + 15

Thread 2:
0   libsystem_pthread.dylib                 0x7ff80b134ac0 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib                 0x7ff80b134ac0 start_wqthread + 0


Thread 0 crashed with X86 Thread State (64-bit):
  rax: 0x0000000101b15161  rbx: 0x00007fb70a80d0a8  rcx: 0x00007fb70b80d400  rdx: 0x0000000104e803c9
  rdi: 0x00000001028f0cec  rsi: 0x0000000101b0a821  rbp: 0x00007ff7be8366c0  rsp: 0x00007ff7be836668
   r8: 0x00007fb70a80d178   r9: 0x0000000000000000  r10: 0x000000000000000a  r11: 0x00000001019b9d2a
  r12: 0x00007fb70a80d108  r13: 0x0000000101a44c28  r14: 0x00007fb70a80d0f8  r15: 0x00007fb70b80d400
  rip: 0x0000000102405464  rfl: 0x0000000000010293  cr2: 0x0000000102405464
  
Logical CPU:     0
Error Code:      0x00000015 (invalid protections for user instruction read)
Trap Number:     14


Binary Images:
       0x1016c8000 -        0x101a2cfff dartaotruntime (*) <4c4c4463-5555-3144-a131-74c9a8ac839a> /Users/USER/*/dartaotruntime
               0x0 - 0xffffffffffffffff ??? (*) <00000000-0000-0000-0000-000000000000> ???
    0x7ff80ada7000 -     0x7ff80ae37b5f dyld (*) <899f1e34-b624-3162-8003-04daa6829461> /usr/lib/dyld
    0x7ff80b0f8000 -     0x7ff80b132ff7 libsystem_kernel.dylib (*) <50c9fa25-ed67-32a5-88f4-92de497b0ec1> /usr/lib/system/libsystem_kernel.dylib
    0x7ff80b133000 -     0x7ff80b13eff7 libsystem_pthread.dylib (*) <5a006814-83f4-3c80-ab1f-528cdd08c0ff> /usr/lib/system/libsystem_pthread.dylib

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=400.1M resident=0K(0%) swapped_out_or_unallocated=400.1M(100%)
Writable regions: Total=750.8M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=750.8M(100%)

                                VIRTUAL   REGION 
REGION TYPE                        SIZE    COUNT (non-coalesced) 
===========                     =======  ======= 
Activity Tracing                   256K        1 
Kernel Alloc Once                    8K        1 
MALLOC                           732.2M       32 
MALLOC guard page                   24K        6 
STACK GUARD                       56.0M        4 
Stack                             10.0M        4 
VM_ALLOCATE                       14.2M       21 
__DATA                            13.4M      265 
__DATA_CONST                      11.2M      169 
__DATA_DIRTY                       457K       93 
__FONT_DATA                        2352        1 
__LINKEDIT                       179.9M        3 
__OBJC_RO                         71.7M        1 
__OBJC_RW                         2196K        2 
__TEXT                           220.2M      286 
dyld private memory                260K        2 
mapped file                       35.1M        6 
shared memory                       60K        6 
===========                     =======  ======= 
TOTAL                              1.3G      903 

I'm not sure where to go from here. Would you mind taking a look @sstrickl?