Skip to content

Analysis server does not report analytics or crashes from non-VS Code clients #55260

Open
@DanTup

Description

@DanTup

Splitting this from https://dart-review.googlesource.com/c/sdk/+/358902.

Currently, analytics and crash reports require a mapping from a client-id to a "DashTool" from unified analytics, but this is only done for VS Code:

if (clientId == 'VS-Code' || clientId == 'VS-Code-Remote') {
analyticsManager = AnalyticsManager(_createAnalytics(
defaultSdk, defaultSdkPath, DashTool.vscodePlugins));
} else {
analyticsManager = AnalyticsManager(NoOpAnalytics());
}

This means non-VS Code clients (including dart analyze, whose client ID is dart-analyze) are not having anything reported. While third party editors using the analysis server might be harder to map, probably first-party commands like dart analyze and IntelliJ (assuming it can show the notification) could still be handled here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2A bug or feature request we're likely to work onanalyzer-stabilityarea-devexpFor issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages.devexp-analyticsdevexp-serverIssues related to some aspect of the analysis servertype-bugIncorrect behavior (everything from a crash to more subtle misbehavior)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions