Skip to content

Eliminate type checks in field setters #40615

Open
@askeksa-google

Description

@askeksa-google

This CL adds missing visitor methods in the TFA transformer. The added handling of implicit setters

        typeChecksNeeded = field.isGenericCovariantImpl;

is more conservative than it needs to be, as it doesn't take information collected by the TFA into account.

Interestingly, the change causes a slight code size regression in Flutter Gallery on ARMv7. Adding more TFA information ought to only improve the compilation, but maybe some inlining instability is at play here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.type-performanceIssue relates to performance or code sizevm-aot-code-sizeRelated to improvements in AOT code sizevm-tfa

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions